Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing broken test as jquery-rails is included in application.js #2239

Merged
merged 1 commit into from Jul 24, 2011

Conversation

mitijain123
Copy link
Contributor

  1. Failure:
    test_scaffold_tests_pass_by_default(ApplicationTests::RakeTest) [test/application/rake_test.rb:245]:
    Expected /7 tests, 10 assertions, 0 failures, 0 errors/ to match "== CreateUsers: migrating ====================================================\n-- create_table(:users)\n -> 0.0017s\n== CreateUsers: migrated (0.0018s) ===========================================\n\nLoaded suite /Users/miteshjain/.rvm/gems/ruby-1.9.2-p180/gems/rake-0.9.2/lib/rake/rake_test_loader\nStarted\n\nFinished in 0.003070 seconds.\n\n0 tests, 0 assertions, 0 failures, 0 errors, 0 skips\n\nTest run options: --seed 18477\nLoaded suite /Users/miteshjain/.rvm/gems/ruby-1.9.2-p180/gems/rake-0.9.2/lib/rake/rake_test_loader\nStarted\n..EEEE.\nFinished in 1.202395 seconds.\n\n 1) Error:\ntest_should_get_edit(UsersControllerTest):\nActionView::Template::Error: couldn't find file 'jquery'\n

@mitijain123
Copy link
Contributor Author

/cc @spastorino

we had removed the assets folder which is not required for this test and if you do not want to remove the assets from app folder, then we need to include the jquery-rails again in gem file.

@spastorino
Copy link
Contributor

We should bring back gem 'jquery-rails' to the Gemfile, please do it :).
What about 3-1-stable?

@mitijain123
Copy link
Contributor Author

This is test is not in 3-1-stable can i add this test there also?

and updating the pull request.

@spastorino
Copy link
Contributor

Don't worry about 3-1-stable, just bring back jquery-rails for master

@mitijain123
Copy link
Contributor Author

Done. :-)

spastorino added a commit that referenced this pull request Jul 24, 2011
fixing broken test as jquery-rails is included in application.js
@spastorino spastorino merged commit 8a9cacb into rails:master Jul 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants