Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip] #22857
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -215,9 +215,9 @@ Much of Action Controller's functionality is implemented as Middlewares. The fol | |||
|
|
|||
| * Used to serve static files from the public directory. Disabled if `config.public_file_server.enabled` is `false`. | |||
|
|
|||
| **`Rack::Lock`** | |||
There was a problem hiding this comment.
I guess this one should stay (in addition to the new one), as we still use it sometimes? ¯_(ツ)_/¯
There was a problem hiding this comment.
The list mirrors the output of rails middleware from a fresh app. I'd say it's covered in configuring.md.
There was a problem hiding this comment.
ping @matthewd - you still think Rack::Lock should be in there even though it is explained in configuring.md?
There was a problem hiding this comment.
@bdewater lets keep this for a comprehensive list. This list doesn't say its only from "rails middleware" output.
There was a problem hiding this comment.
@vipulnsward ok, I just force pushed a new commit so Rack::Lock is back in.
|
Thanks! |
bdewater
force-pushed
the
interlock-doc
branch
from
26be096
to
6cdc36a
Compare
Update middleware docs regarding ActionDispatch::LoadInterlock [ci skip]
|
Thanks @bdewater ! |
Noticed that the guides didn't mention this feature yet. Figured it was safe to remove the Rack::Lock references for the cache middleware because it's not something that is encountered in default configurations.
r? @matthewd