Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that app/mailers gets created in new plugins #2287

Merged
merged 1 commit into from
Jul 27, 2011
Merged

Ensure that app/mailers gets created in new plugins #2287

merged 1 commit into from
Jul 27, 2011

Conversation

dgeb
Copy link
Contributor

@dgeb dgeb commented Jul 26, 2011

When calling "rails plugin new [plugin_name] --full", an app/mailers directory was not created in the resultant plugin. This pull request corrects that.

@dgeb
Copy link
Contributor Author

dgeb commented Jul 27, 2011

I am puzzled. This commit shows two diffs, yet shows only a single file in the github viewer. My intention was to also include the following directory by committing a .empty_directory file:
https://github.com/dgeb/rails/tree/3-1-mailers-in-plugins/railties/lib/rails/generators/rails/plugin_new/templates/app/mailers

The reason I wanted to include this directory is that it's apparently missing from:
https://github.com/rails/rails/tree/3-1-stable/railties/lib/rails/generators/rails/plugin_new/templates/app

I don't know why this directory and .empty_directory file seem to be missing from this commit. Perhaps it's there and there is a glitch in the github viewer?

Anyway, the point is that this needs to get into 3-1-stable so that the full app structure is available for new plugins. Thanks in advance.

josevalim added a commit that referenced this pull request Jul 27, 2011
Ensure that app/mailers gets created in new plugins
@josevalim josevalim merged commit a9dea60 into rails:3-1-stable Jul 27, 2011
@josevalim
Copy link
Contributor

Merged. And yes, probably a github bug.

@dgeb
Copy link
Contributor Author

dgeb commented Jul 27, 2011

Looks like the directory made it with the merge, so I guess you're right. Thanks for the merge and the clarification.

@dgeb
Copy link
Contributor Author

dgeb commented Jul 28, 2011

@josevalim - looks like this still needs to be merged with master. For future reference, would it have been better for me to target master and then ask you to backport to 3-1-stable?

@josevalim
Copy link
Contributor

Yes! Could you please provide a patch for master and ping me? :) Thanks for everything!

@dgeb
Copy link
Contributor Author

dgeb commented Jul 29, 2011

@josevalim - Glad to help :) Please see #2339

josevalim added a commit that referenced this pull request Jul 29, 2011
Ensure that app/mailers gets created in new plugins (#2287 brought into master)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants