Get update_attributes working with SchemaMigration #22976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sgrif |
|
You have a test that needs to be updated. |
You cannot use `update_attributes` on models that do not have a primary key. Since SchemaMigration versions are guaranteed to be unique (they have a unique index on them) we can safely use them as a primary key.
schneems
force-pushed
the
schneems/schema-migration-primary-key
branch
from
fca9e4f
to
5715506
Compare
schneems
referenced
this pull request
Jan 8, 2016
Before this patch, using `ActiveRecord::Base.primary_key_prefix_type` with `:table_name_with_underscore` would change the `SchemaMigration` model to have a primary key. This resulted in broken queries for PG because it tried to return the inserted PK (which does not exist). Closes #15051. Closes #15419.
|
ATP |
sgrif
added a commit
that referenced
this pull request
Jan 9, 2016
…mary-key Get update_attributes working with SchemaMigration
prathamesh-sonpatki
added a commit
to prathamesh-sonpatki/rails
that referenced
this pull request
Jan 9, 2016
schneems
added a commit
that referenced
this pull request
Jan 9, 2016
…long-for-schema-migrations-version Added missing CHANGELOG entry for #22976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot use
update_attributeson models that do not have a primary key. Since SchemaMigration versions are guaranteed to be unique (they have a unique index on them) we can safely use them as a primary key.