Permalink
Browse files

`ActiveRecord::SchemaMigration` has no primary key.

Before this patch, using `ActiveRecord::Base.primary_key_prefix_type`
with `:table_name_with_underscore` would change the `SchemaMigration` model
to have a primary key. This resulted in broken queries for PG because it tried
to return the inserted PK (which does not exist).

Closes #15051.
Closes #15419.
  • Loading branch information...
1 parent d23cbbb commit 8fa8b7124b4a28591c47883199f9d6bdd77a827e @senny senny committed Jun 6, 2014
@@ -1,3 +1,10 @@
+* `ActiveRecord::SchemaMigration` has no primary key regardless of the
+ `primary_key_prefix_type` configuration.
+
+ Fixes #15051.
+
+ *Yves Senn*
+
* `rake db:migrate:status` works with legacy migration numbers like `00018_xyz.rb`.
Fixes #15538.
@@ -5,6 +5,9 @@
module ActiveRecord
class SchemaMigration < ActiveRecord::Base
class << self
+ def primary_key
+ nil
+ end
def table_name
"#{table_name_prefix}#{ActiveRecord::Base.schema_migrations_table_name}#{table_name_suffix}"
@@ -17,6 +17,20 @@ def setup
ActiveRecord::SchemaMigration.delete_all rescue nil
end
+ def test_has_no_primary_key
+ old_primary_key_prefix_type = ActiveRecord::Base.primary_key_prefix_type
+ ActiveRecord::Base.primary_key_prefix_type = :table_name_with_underscore
+ assert_nil ActiveRecord::SchemaMigration.primary_key
+
+ ActiveRecord::SchemaMigration.create_table
+ assert_difference "ActiveRecord::SchemaMigration.count", 1 do
+ ActiveRecord::SchemaMigration.create version: 12
+ end
+ ensure
+ ActiveRecord::SchemaMigration.drop_table
+ ActiveRecord::Base.primary_key_prefix_type = old_primary_key_prefix_type
+ end
+
def test_schema_define
ActiveRecord::Schema.define(:version => 7) do
create_table :fruits do |t|

2 comments on commit 8fa8b71

Member

schneems replied Jan 8, 2016

Hey Senny, can you take a look at #22976 any problems you see with specifying a primary key of "version" for SchemaMigration?

Member

senny replied Jan 11, 2016

@schneems using version as primary key seems fine 👍

Please sign in to comment.