Pass 2 over testing guide #23208
Merged
Pass 2 over testing guide #23208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
| @@ -589,9 +589,9 @@ class BlogFlowTest < ActionDispatch::IntegrationTest | |||
| end | |||
| ``` | |||
|
|
|||
| If you remember from earlier in the "Testing Views" section we covered `assert_select` to query the resulting HTML of a request. | |||
| We will take a look at `assert_select` to query the resulting HTML of a request in the "Testing Views" section below. It is used for testing the response of our request by asserting the presence of key HTML elements and their content. | |||
There was a problem hiding this comment.
Question: Is this section out of order? We were referring to "Testing Views" which is defined later.
I think, we can move integration tests below others.
cc @zzak
There was a problem hiding this comment.
IMO, we should leave it. To me, at least, it fits with the flow of the section it's apart of.
| @@ -546,17 +546,17 @@ class UserFlowsTest < ActionDispatch::IntegrationTest | |||
| end | |||
| ``` | |||
|
|
|||
| Inheriting from `ActionDispatch::IntegrationTest` comes with some advantages. This makes available some additional helpers to use in your integration tests. | |||
| Here the test is inheriting from `ActionDispatch::IntegrationTest`. This makes available some additional helpers to use in our integration tests. | |||
There was a problem hiding this comment.
This makes some additional helpers available for us to use in our integration tests.
|
So far, looks fine to me, with a few comments. |
vipulnsward
force-pushed
the
testing-pass-2
branch
from
434df88
to
6026b37
Compare
- Grammar fixes - Wordsmitting - Fixed wrong statement about association usage in fixtures - Changed association name from 'one' to 'first' instead - More consistent usage of we/our - Mentions assert_select is below, not already covered in Integration test. [ci skip]
|
@maclover7 updated. The above question remains. Can handle in other request after confirmation. |
|
👍 Thank you for your contribution! |
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]