Extract arel_visitor and move up to the abstract adapter
#23515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
extract_arel_visitor
branch
from
c48cd01
to
3cdc180
Compare
| @@ -143,6 +149,10 @@ def collector | |||
| end | |||
| end | |||
|
|
|||
| def arel_visitor # :nodoc: | |||
| (Arel::Visitors::VISITORS[@config[:adapter]] || Arel::Visitors::ToSql).new(self) | |||
There was a problem hiding this comment.
Why fallback to Arel::Visitors::ToSql?
I think it is better to override this method if someone create an adapter that Arel does not support.
There was a problem hiding this comment.
This code is derived from https://github.com/rails/arel/blob/v7.0.0/lib/arel/visitors.rb#L33.
kamipo
force-pushed
the
extract_arel_visitor
branch
from
3cdc180
to
4087c5c
Compare
kamipo
force-pushed
the
extract_arel_visitor
branch
from
4087c5c
to
c3508bf
Compare
kamipo
force-pushed
the
extract_arel_visitor
branch
from
c3508bf
to
8200b3b
Compare
jeremy
added a commit
that referenced
this pull request
Apr 19, 2016
Extract `arel_visitor` and move up to the abstract adapter
|
Is this a permanent change? It breaks Ransack's Active Record adapter: |
|
hmm... |
|
Fixed by #24634. |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jun 7, 2016
kamipo
added a commit
that referenced
this pull request
Jan 15, 2019
…sage This attr writer was introduced at 7db90aa, but the usage is already removed at bd2f5c0 before v3.2.0.rc1 is released. If we'd like to customize the visitor in the connection, `arel_visitor` which is implemented in all adapters (mysql2, postgresql, sqlite3, oracle-enhanced, sqlserver) could be used for the purpose #23515.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.