Add prepared statements support for Mysql2Adapter
#23461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @chancancode (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
2 times, most recently
from
63b18e6 to
22858f6
Compare
| @@ -126,6 +141,10 @@ def supports_datetime_with_precision? | |||
| version >= '5.6.4' | |||
| end | |||
|
|
|||
| def supports_json? | |||
There was a problem hiding this comment.
This seems unrelated to prepared statement support
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
2 times, most recently
from
07e428d to
c962972
Compare
|
This will need to handle nodes which we consider to be unpreparable, similar to what we do in PG and SQLite. We can probably just move that logic up to the abstract adapter now. |
|
Do you means #23515? |
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
3 times, most recently
from
a370e7c to
c021804
Compare
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
2 times, most recently
from
8980117 to
d7f30c2
Compare
|
I've just pushed mysql2 0.4.3 with important prepared statement fixes from @kamipo! |
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
3 times, most recently
from
428f612 to
86b2576
Compare
|
Rebase time 😊 |
| end | ||
| else | ||
| exec_stmt_and_free(sql, name, binds, cache_stmt: prepare) do |_, result| | ||
| ActiveRecord::Result.new(result.fields, result.to_a) if result |
There was a problem hiding this comment.
In mysql2 0.4.3, result.fields causes segv when num of rows is zero.
This issue was fixed on master by brianmario/mysql2#741.
@sodabrew Could you release mysql2 0.4.4?
There was a problem hiding this comment.
Done! mysql2 0.4.4 is now on Rubygems.org.
|
I've just posted mysql2 0.4.4 with additional prepared statement fixes from @kamipo! |
|
Thanks @sodabrew !! 😍 |
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
from
86b2576 to
c2c5708
Compare
|
Rebased on master! |
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
from
c2c5708 to
bc7fe67
Compare
|
Changing to 5.0 since prepared statements are disabled by default. |
| # Executes the SQL statement in the context of this connection. | ||
| def execute(sql, name = nil) | ||
| log(sql, name) { @connection.query(sql) } | ||
| end | ||
|
|
||
| # Mysql2Adapter doesn't have to free a result after using it, but we use this method | ||
| # to write stuff in an abstract way without concerning ourselves about whether it | ||
| # needs to be explicitly freed or not. | ||
| def execute_and_free(sql, name = nil) # :nodoc: |
There was a problem hiding this comment.
We can remove this method here in a different PR. This abstract class can be removed too since we only have one concrete class.
kamipo
force-pushed
the
prepared_statements_for_mysql2_adapter
branch
from
14dd46f to
3f6574e
Compare
|
|
||
| gem 'mysql2', '>= 0.3.18', '< 0.5' | ||
| gem 'mysql2', '~> 0.4.4' |
There was a problem hiding this comment.
Do we need to bump mysql2 minimum version? 0.4.x is only required if prepared_statements: true.
There was a problem hiding this comment.
Unfortunately, mysql2 0.4.3 was broken without prepared statements.
I would like to skip this version.
jeremy
added a commit
that referenced
this pull request
Apr 24, 2016
…adapter Add prepared statements support for `Mysql2Adapter`
vipulnsward
added a commit
to vipulnsward/rails
that referenced
this pull request
Apr 24, 2016
[ci skip]
|
Hurray! |
vipulnsward
added a commit
to vipulnsward/rails
that referenced
this pull request
Apr 24, 2016
- Rename max to statement_limit - Remove magic number 1000 from everywhere - Defined StatementPool::DEFAULT_STATEMENT_LIMIT and started using it everywhere
jeremy
pushed a commit
that referenced
this pull request
Apr 24, 2016
- Rename max to statement_limit - Remove magic number 1000 from everywhere - Defined StatementPool::DEFAULT_STATEMENT_LIMIT and started using it everywhere Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
This was referenced Jan 21, 2017
kamipo
added a commit
that referenced
this pull request
Mar 5, 2019
Since #23461, all adapters supports prepared statements, so that clears the prepared statements cache is no longer database specific. Actually, I struggled to identify the cause of random CI failure in #23461, that was missing `@statements.clear` in `clear_cache!`. This extracts `clear_cache!` to ensure the common concerns in the abstract adapter.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jan 14, 2021
Revert "Revert "Merge pull request rails#39613 from kamipo/where_with_custom_operator"" This reverts commit da02291. ```ruby posts = Post.order(:id) posts.where("id >": 9).pluck(:id) # => [10, 11] posts.where("id >=": 9).pluck(:id) # => [9, 10, 11] posts.where("id <": 3).pluck(:id) # => [1, 2] posts.where("id <=": 3).pluck(:id) # => [1, 2, 3] ``` From type casting and table/column name resolution's point of view, `where("created_at >=": time)` is better alternative than `where("created_at >= ?", time)`. ```ruby class Post < ActiveRecord::Base attribute :created_at, :datetime, precision: 3 end time = Time.now.utc # => 2020-06-24 10:11:12.123456 UTC Post.create!(created_at: time) # => #<Post id: 1, created_at: "2020-06-24 10:11:12.123000"> # SELECT `posts`.* FROM `posts` WHERE (created_at >= '2020-06-24 10:11:12.123456') Post.where("created_at >= ?", time) # => [] # SELECT `posts`.* FROM `posts` WHERE `posts`.`created_at` >= '2020-06-24 10:11:12.123000' Post.where("created_at >=": time) # => [#<Post id: 1, created_at: "2020-06-24 10:11:12.123000">] ``` As a main contributor of the predicate builder area, I'd recommend to people use the hash syntax, the hash syntax also have other useful effects (making boundable queries, unscopeable queries, hash-like relation merging friendly, automatic other table references detection). * Making boundable queries While working on rails#23461, I realized that Active Record doesn't generate boundable queries perfectly, so I've been improving generated queries to be boundable for a long time. e.g. rails#26117 7d53993 rails#39219 Now, `where` with the hash syntax will generate boundable queries perfectly. I also want to generate boundable queries with a comparison operator in a third party gem, but currently there is no other way than calling `predicate_builder` directly. kufu/activerecord-bitemporal#62 * Unscopeable queries, Hash-like relation merging friendly Unscopeable, and Hash-like merging friendly queries are relying on where clause is an array of attr with value, and attr name is normalized as a string (i.e. using `User.arel_table[:name]` is not preferable for `unscope` and `merge`). Example: ```ruby id = User.arel_table[:id] users = User.where(id.gt(1).and(id.lteq(10))) # no-op due to `id.gt(1).and(id.lteq(10))` is not an attr with value users.unscope(:id) ``` * Automatic other table references detection It works only for the hash syntax. ee7f666
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Mar 11, 2021
Revert "Revert "Merge pull request rails#39613 from kamipo/where_with_custom_operator"" This reverts commit da02291. ```ruby posts = Post.order(:id) posts.where("id >": 9).pluck(:id) # => [10, 11] posts.where("id >=": 9).pluck(:id) # => [9, 10, 11] posts.where("id <": 3).pluck(:id) # => [1, 2] posts.where("id <=": 3).pluck(:id) # => [1, 2, 3] ``` From type casting and table/column name resolution's point of view, `where("created_at >=": time)` is better alternative than `where("created_at >= ?", time)`. ```ruby class Post < ActiveRecord::Base attribute :created_at, :datetime, precision: 3 end time = Time.now.utc # => 2020-06-24 10:11:12.123456 UTC Post.create!(created_at: time) # => #<Post id: 1, created_at: "2020-06-24 10:11:12.123000"> # SELECT `posts`.* FROM `posts` WHERE (created_at >= '2020-06-24 10:11:12.123456') Post.where("created_at >= ?", time) # => [] # SELECT `posts`.* FROM `posts` WHERE `posts`.`created_at` >= '2020-06-24 10:11:12.123000' Post.where("created_at >=": time) # => [#<Post id: 1, created_at: "2020-06-24 10:11:12.123000">] ``` As a main contributor of the predicate builder area, I'd recommend to people use the hash syntax, the hash syntax also have other useful effects (making boundable queries, unscopeable queries, hash-like relation merging friendly, automatic other table references detection). * Making boundable queries While working on rails#23461, I realized that Active Record doesn't generate boundable queries perfectly, so I've been improving generated queries to be boundable for a long time. e.g. rails#26117 7d53993 rails#39219 Now, `where` with the hash syntax will generate boundable queries perfectly. I also want to generate boundable queries with a comparison operator in a third party gem, but currently there is no other way than calling `predicate_builder` directly. kufu/activerecord-bitemporal#62 * Unscopeable queries, Hash-like relation merging friendly Unscopeable, and Hash-like merging friendly queries are relying on where clause is an array of attr with value, and attr name is normalized as a string (i.e. using `User.arel_table[:name]` is not preferable for `unscope` and `merge`). Example: ```ruby id = User.arel_table[:id] users = User.where(id.gt(1).and(id.lteq(10))) # no-op due to `id.gt(1).and(id.lteq(10))` is not an attr with value users.unscope(:id) ``` * Automatic other table references detection It works only for the hash syntax. ee7f666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #22415.
Currently mysql2 adapter does not support prepared statements. And mysql adapter has been removed. This means that Active Record does not support prepared statements for MySQL now.
We need to support prepared statements for MySQL. But mysql2 gem still have GC issue in prepared statements. brianmario/mysql2#694
I made default to
@prepared_statements = falseinMysql2Adapterfor does not affect default behavior. I think it is still safety.