Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric type in the doc [ci skip] #23558

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Feb 8, 2016

Follow up to #23508.

@rails-bot
Copy link

r? @chancancode

(@rails-bot has picked a reviewer for you, use r? to override)

@@ -477,9 +477,9 @@ def drop_table(table_name, options = {})
# Allows or disallows +NULL+ values in the column. This option could
# have been named <tt>:null_allowed</tt>.
# * <tt>:precision</tt> -
# Specifies the precision for a <tt>:decimal</tt> column.
# Specifies the precision for <tt>:decimal</tt> and <tt>:numeric</tt> columns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precision for the

@maclover7
Copy link
Contributor

Small grammar notes, then ready to merge.

@kamipo
Copy link
Member Author

kamipo commented Feb 8, 2016

I fixed grammar, thanks!

vipulnsward added a commit that referenced this pull request Feb 8, 2016
Add numeric type in the doc [ci skip]
@vipulnsward vipulnsward merged commit d3150c8 into rails:master Feb 8, 2016
@vipulnsward
Copy link
Member

Thanks @kamipo !

@kamipo
Copy link
Member Author

kamipo commented Feb 8, 2016

😄

@kamipo kamipo deleted the add_numeric_type_in_doc branch February 8, 2016 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants