fix stringify_keys destructive behavior for most FormTagHelper functions

[waynn]

I've also filed this at #2355

[spastorino]

Please test each method and squash it with your current commit. Thanks :)

[spastorino]

Also add Closes #2355 to your commit message, so github can automatically close it when merged.

[waynn]

Sure! So I should just add a test for each of the other two methods that
I've changed, and on that commit, add the phrase "Closes #2355" somewhere in
it?

On Sat, Jul 30, 2011 at 4:00 PM, spastorino <
reply@reply.github.com>wrote:

Also add Closes #2355 to your commit message, so github can automatically
close it when merged.

Reply to this email directly or view it on GitHub:
#2356 (comment)

[spastorino]

yes

[waynn]

I've committed a change with three new tests--anything else I should add to it?

[spastorino]

One more thing can you squash your commits into one? Remember to keep the Closes #2355 message

[waynn]

Sorry, can you help me with squashing the commits? I followed the guide here: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html but at the end of it, I had three commits instead of one. Then when I tried rebasing again (thinking it was a merge error), I got this.

Is it because I did a push 3 days ago, so I can't use rebase?

wlue:~/code/rails$ git rebase -i 2b925e8
error: could not apply 9c5c1dd... fix stringify_keys destructive behavior for most FormTagHelper functions
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' and run 'git rebase --continue'

Could not apply 9c5c1dd... fix stringify_keys destructive behavior for most FormTagHelper functions

edit: removed sample code

[waynn]

Ah-ha! I think it was because I didn't do git push -f, but instead did a git pull first. Does this currently look correct?