Remove references to Rails 4 from assets guide [ci skip] #23560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from other gems. For example, jquery-rails includes a copy of jquery.js | ||
| and enables AJAX features in Rails. | ||
|
|
||
| The asset pipeline is technically no longer a core feature of Rails 4, it has | ||
| The asset pipeline is technically no longer a core feature from Rails 4 onwards, it has |
There was a problem hiding this comment.
while the PR is open, can you change the comma to a "--"?
prathamesh-sonpatki
force-pushed
the
rm-rails-4-from-assets-guide
branch
from
8f58737
to
abef3c2
Compare
|
@maclover7 done :) |
| @@ -21,11 +21,11 @@ What is the Asset Pipeline? | |||
| The asset pipeline provides a framework to concatenate and minify or compress | |||
| JavaScript and CSS assets. It also adds the ability to write these assets in | |||
| other languages and pre-processors such as CoffeeScript, Sass and ERB. | |||
| It allows assets in your application to be automatically combined with assets | |||
| It allows assets in your application to be automatically combined with assets | |||
There was a problem hiding this comment.
It's whitespace change and do we allow such changes when we are updating a file without having too much git churn.
|
Merging this, thanks for the review everyone. |
prathamesh-sonpatki
added a commit
that referenced
this pull request
Feb 8, 2016
…sets-guide Remove references to Rails 4 from assets guide [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.