-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix argument passing to rake routes #23612
Conversation
r? @kaspth |
Users shouldn't have to do this. We should make |
@kaspth routes has been a rake task before. To still use it that way, we will need to let it remain a rake task, to be backward compatible. Other option is we drop the rake task support and convert this to a rails command. |
@dhh how does having to pass |
You have to do -- twice? That doesn't work for me at all. May even be worse than passing ENVs like Rake did. |
To be more productive. If we can't do long-version nicely, maybe just don't do long version at all? -g and -c seem fine to me. |
Yeah, I was thinking that too. Would be a better compromise than automatically trying to insert |
7c3d55f
to
b7c9272
Compare
Ok, updated to remove long arguments. Short args work as expected. |
b7c9272
to
c11c109
Compare
@@ -19,11 +19,11 @@ task routes: :environment do | |||
|
|||
OptionParser.new do |opts| | |||
opts.banner = "Usage: rails routes [options]" | |||
opts.on("-c", "--controller [CONTROLLER]") do |controller| | |||
opts.on("-cCONTROLLER") do |controller| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we have a space between -c
and CONTROLLER
?
- Fixed related documentation and usage all around Fixes rails#23561
c11c109
to
ef2a8c2
Compare
Done. |
Fix argument passing to rake routes
Sweet! |
🍠 |
Fixes #23561