Simple_format should not edit it in place. (Fixes https://github.com/rails/rails/issues/1980) #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext in place. Now it duplicates it.
spastorino
added a commit
that referenced
this pull request
Aug 4, 2011
Simple_format should not edit it in place. (Fixes #1980)
|
Any chance someone can backport this to 3-0-stable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionView::Helpers::TextHelper#simple_format should not change the text in place. Now it duplicates it.
simple_format should not edit the string in place, but rather should duplicate and return a modified copy. We were running into the cumulative paragraphs error (see #1980). Also note that this was changing the string pointed to by the model, if only for the duration of the request. This is bad.