Fix description for method ActiveRecord::ConnectionAdapters::SchemaStatements#add_timestamps [ci skip] #24328
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -1051,9 +1051,9 @@ def columns_for_distinct(columns, orders) # :nodoc: | |||
| end | |||
|
|
|||
| # Adds timestamps (+created_at+ and +updated_at+) columns to +table_name+. | |||
| # Additional options (like <tt>null: false</tt>) are forwarded to #add_column. | |||
| # Additional options (like <tt>null: true</tt>) are forwarded to #add_column. | |||
There was a problem hiding this comment.
Actually I think both are true ; this method forward all the given options, it just sets :null to false if the option isn't yet specified. What do you think about writing Additional options (like +:null+) are forwarded ?
There was a problem hiding this comment.
You right, it will be better.
|
@bogdanvlviv Can you squash the commits? |
|
Yes, sure. |
…atements#add_timestamps [ci skip]
bogdanvlviv
changed the title
|
@prathamesh-sonpatki, i did it. |
|
Thanks @bogdanvlviv ! |
No description provided.