[ci skip] relations inside <tt> tag #24337
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -504,7 +504,7 @@ def association_instance_set(name, association) | |||
| # | |||
| # == Customizing the query | |||
| # | |||
| # \Associations are built from <tt>Relation</tt>s, and you can use the Relation syntax | |||
| # \Associations are built from <tt>Relations</tt>, and you can use the Relation syntax | |||
There was a problem hiding this comment.
I agree that it looks odd on the API site but what do you think about Associations are built from +Relation+ objects ?
There was a problem hiding this comment.
Better. s can't be part of the <tt> font here. @xw19 can you incorporate this change?
|
okay |
xw19
force-pushed
the
realations-properly
branch
from
37a2b46
to
6121e31
Compare
|
@vipulnsward 's' removed |
| @@ -504,7 +504,7 @@ def association_instance_set(name, association) | |||
| # | |||
| # == Customizing the query | |||
| # | |||
| # \Associations are built from <tt>Relation</tt>s, and you can use the Relation syntax | |||
| # \Associations are built from <tt>Relation</tt>, and you can use the Relation syntax | |||
There was a problem hiding this comment.
Actually, I meant to incorporate @robin850 's suggestion to make if more simpler.
Associations are built from <tt>Relation</tt> objects, ..
|
okay |
s removed objects added
xw19
force-pushed
the
realations-properly
branch
from
6121e31
to
975efb2
Compare
|
Done |
|
Thanks @xw19 ! |
The Relations word wrapped inside the
<tt>tag so that it doesn't look odd. Earlier it was looking like "RelationS"