update assert_no_performed_jobs doc to use assert_no_performed_jobs method [ci skip]
#24350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arthurnn (@rails-bot has picked a reviewer for you, use r? to override) |
| # end | ||
| # | ||
| # An array may also be specified, to support testing multiple jobs. | ||
| # It can be asserted that no jobs of a specific kind are performed: |
There was a problem hiding this comment.
@y-yagi we can expand similar to above deleted documentation, to specify which option is used to perform the filtering.
There was a problem hiding this comment.
@vipulnsward Thanks for reviewing. I updated.
|
I'm 👎 on this. I think the intention of the original docs are clearer. We're making assertions about a given job and Though I'm 👍 on adding a separate example for |
|
Doh! I see that I was wrong and we're documenting the wrong assertion. Never mind me, 👍 |
…s` method [ci skip]
y-yagi
force-pushed
the
update_assert_no_performed_jobs_doc
branch
from
1ff2daa
to
87824ab
Compare
|
Thanks @y-yagi ! |
|
Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a example to use the
assert_performed_jobsinassert_no_performed_jobs's doc, but I think this is a mistake.