Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor to delegate #2444

Merged
merged 1 commit into from Aug 6, 2011
Merged

Minor refactor to delegate #2444

merged 1 commit into from Aug 6, 2011
+11 −5

Conversation

elight
Copy link

@elight elight commented Aug 6, 2011

  • Replaced a single line double-ternary with a more idiomatic functional use of if-else.
  • Replaced repeated options Hash [] calls with a parallel assignment.

@elight
Copy link
Author

elight commented Aug 6, 2011

BTW: I checked the existing delegation tests before pushing. No changes appeared to be necessary there.

spastorino added a commit that referenced this pull request Aug 6, 2011
@spastorino
Merge pull request #2444 from elight/master
81eb5b3 
Minor refactor to delegate
@spastorino spastorino merged commit 81eb5b3 into rails:master Aug 6, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elight @spastorino