MariaDB documentation #24454
MariaDB documentation #24454
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@iangilfillan You might want to put skip-ci in the future for doc changes to avoid travis running the test suite. |
|
We need to actively be running tests against MariaDB before we add this. |
| @@ -53,7 +53,7 @@ Documentation has to be concise but comprehensive. Explore and document edge cas | |||
|
|
|||
| The proper names of Rails components have a space in between the words, like "Active Support". `ActiveRecord` is a Ruby module, whereas Active Record is an ORM. All Rails documentation should consistently refer to Rails components by their proper name, and if in your next blog post or presentation you remember this tidbit and take it into account that'd be phenomenal. | |||
|
|
|||
| Spell names correctly: Arel, Test::Unit, RSpec, HTML, MySQL, JavaScript, ERB. When in doubt, please have a look at some authoritative source like their official documentation. | |||
| Spell names correctly: Arel, Test::Unit, RSpec, HTML, MySQL, MariaDB, JavaScript, ERB. When in doubt, please have a look at some authoritative source like their official documentation. | |||
|
Basecamp 3 runs on MariaDB 10.1. Happy to proclaim broader support! Travis supports MariaDB 10.0 via an addon. We'll have to set that up in a separate PR. |
|
I can look into it. |
|
@jeremy do you want me to make the suggested changes on my side and re-commit? |
|
@iangilfillan Please do! |
|
@iangilfillan two more changes and a squash of commits, before we merge. Can you take care of it. |
| @@ -372,6 +372,6 @@ Rails keeps track of which files have been committed to the database and | |||
| provides rollback features. To actually create the table, you'd run `rails db:migrate` | |||
| and to roll it back, `rails db:rollback`. | |||
|
|
|||
| Note that the above code is database-agnostic: it will run in MySQL, | |||
| Note that the above code is database-agnostic: it will run in MySQL, | |||
There was a problem hiding this comment.
Being nitpicky, but can you revert this, there is not change here. 😄
|
Thanks @iangilfillan 💚 |
Add support for MariaDB to the documentation