Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass over all Rails 5 warnings #24492

Merged
merged 1 commit into from
Apr 11, 2016
Merged

Pass over all Rails 5 warnings #24492

merged 1 commit into from
Apr 11, 2016

Conversation

vipulnsward
Copy link
Member

Pass over all Rails 5 warnings, to make sure:

  • we are ending sentences properly
  • fixing of space issues
  • fixed continuity issues in some sentences.

This is continuation of #24485 and takes care of warnings at all places.

@vipulnsward
Copy link
Member Author

Unrelated test failure.

@jonatack
Copy link
Contributor

For deprecation warnings, AS::Deprecation::Reporting line 68 adds missing periods to ends of sentences, I believe.

@vipulnsward
Copy link
Member Author

Gah. Dumb of me. Anyway, will get others feedback if we want to just keep this now, else will remove those from this patch.

@vipulnsward
Copy link
Member Author

r? @rafaelfranca

@jeremy
Copy link
Member

jeremy commented Apr 11, 2016

I'd keep the periods you added. It feels strange to auto-add missing punctuation rather than properly punctuating the warnings in the first place. Turns out I added this, maybe to avoid updating the many warning messages. I'd prefer to see it go 😁

vipulnsward
vipulnsward reviewed Apr 11, 2016
View reviewed changes
activesupport/lib/active_support/deprecation/reporting.rb
@@ -65,7 +65,6 @@ def deprecated_method_warning(method_name, message = nil)

def deprecation_message(callstack, message = nil)
message ||= "You are using deprecated behavior which will be removed from the next major or minor release."
message += '.' unless message =~ /\.$/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremy done. Now making sure the sentence ends with '.' lies at where ever it's defined.
Before 8fc97d1, we relied on '.' being present in sentences.

@jeremy
Copy link
Member

jeremy commented Apr 11, 2016

Would you squash the revert onto the other commit? Then we have a single commit that drops the period-addition behavior and adds missing periods.

@vipulnsward
Pass over all Rails 5 warnings, to make sure:
ac02733 
- we are ending sentences properly
- fixing of space issues
- fixed continuity issues in some sentences.

Reverts rails@8fc97d1 .
This change reverts making sure we add '.' at end of deprecation sentences.
This is to keep sentences within Rails itself consistent and with a '.' at the end.
@vipulnsward
Copy link
Member Author

Squashed.

@jonatack
Copy link
Contributor

Yes. Perhaps update the PR title to something like "Clean up warning messages and revert auto-adding periods."

@jeremy jeremy merged commit 1a5fdf7 into rails:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafaelfranca rafaelfranca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vipulnsward @jonatack @jeremy @rafaelfranca