Added notice when a database is successfully created or dropped. #24551

bogdanvlviv · 2016-04-14T13:54:48Z

Added notice when a database is successfully created or dropped.

Example:

  $ bin/rails db:create
  Created database 'blog_development'
  Created database 'blog_test'

  $ bin/rails db:drop
  Dropped database 'blog_development'
  Dropped database 'blog_test'

Changed older notices
blog_development already exists to Database 'blog_development' already exists and
Couldn't drop blog_development to Couldn't drop database 'blog_development'.

rails-bot · 2016-04-14T13:54:51Z

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

maclover7 · 2016-04-14T17:24:09Z

activerecord/lib/active_record/tasks/database_tasks.rb

@@ -107,8 +107,9 @@ def current_config(options = {})
      def create(*arguments)
        configuration = arguments.first
        class_for_adapter(configuration['adapter']).new(*arguments).create
+        $stdout.puts "Create database '#{configuration['database']}'"


Create --> Created

bogdanvlviv · 2016-04-14T17:29:51Z

I am trying fix tests. I don't know how i can delete from test's logs this. Could you help me?

......S............................................................................
...........................................................................
..............................................................................
...................................................................................
.................................................................................
............................................
.Created database 'my-app-db'
.Created database 'my-app-db'
.Created database 'my-app-db'
.Created database 'my-app-db'
.Created database 'my-app-db'
.Created database 'my-app-db'
.Created database 'my-app-db'
.Dropped database 'my-app-db'
.Dropped database 'my-app-db'
.........................................
........................................
...........................................................

maclover7 · 2016-04-14T17:31:52Z

Can you push up your changes -- I'm not sure which tests you are trying to run above ^^

bogdanvlviv · 2016-04-14T18:07:27Z

@vipulnsward, i think PR should have label 'activerecord'.

jeremy · 2016-04-15T04:48:32Z

activerecord/test/cases/tasks/mysql_rake_test.rb

+      $stdout.expects(:puts).with("Dropped database 'my-app-db'").once
+
+      ActiveRecord::Tasks::DatabaseTasks.drop @configuration
+    end
  end

  class MySQLPurgeTest < ActiveRecord::TestCase


succsessfylly → successfully

jeremy · 2016-04-15T04:55:28Z

I don't know how i can delete from test's logs this

To suppress that output from the test logs, you could introduce an ouput @logger = Logger.new($stdout) and use @logger.info instead of $stdout.puts.

Then, in tests, set logger to @test_output = StringIO.new; @logger = Logger.new(@test_output) instead.

That'll capture all output without needing to $stdout.expect(:puts), too: you can assert against @test_output.string contents.

bogdanvlviv · 2016-04-15T05:37:08Z

@jeremy, i have got log output:

#` Running:

...I, [2016-04-15T08:31:36.130198 #7403]  INFO -- : Created database 'db_create.sqlite3'
.I, [2016-04-15T08:31:36.133723 #7403]  INFO -- : Created database 'db_create.sqlite3'
..I, [2016-04-15T08:31:36.143367 #7403]  INFO -- : Created database 'db_create.sqlite3'`
.........

bogdanvlviv · 2016-04-15T06:23:46Z

@jeremy, will be correctly if i set in tests?

@original_stdout = $stdout
$stdout = StringIO.new

jeremy · 2016-04-15T16:51:38Z

Give it a shot, @bogdanvlviv! How'd it work out for you?

bogdanvlviv · 2016-04-15T17:17:32Z

@jeremy, i am trying make better.

bogdanvlviv · 2016-04-15T20:56:20Z

I have done suppress the output from the test logs. Could this PR be revised?

maclover7 · 2016-04-15T21:01:46Z

activerecord/CHANGELOG.md

@@ -4,6 +4,28 @@

    *Sean Griffin*

+*   Added notice when database successfully created or dropped.


when a database is

Edouard-chin · 2016-04-15T21:12:34Z

activerecord/test/cases/tasks/sqlite_rake_test.rb

@@ -15,6 +15,9 @@ def setup
      File.stubs(:exist?).returns(false)
      ActiveRecord::Base.stubs(:connection).returns(@connection)
      ActiveRecord::Base.stubs(:establish_connection).returns(true)
+
+      @original_stdout = $stdout


I can't see any use of the @original_stdout instance variable.
Should we assert on the content of this variable instead of $stdout.expects(:puts) as @jeremy mentioned?

@Edouard-chin, yes, i dont use @original_stdout. i defined this variable because of i think it is correctly save link to original $stdout, as you can see i override $stdout for tests in next line after defining @original_stdout.

Set $stdout = @original_stdout in teardown to ensure we don't hijack stdout for other tests.

@jeremy, thanks!

jeremy · 2016-04-15T22:39:31Z

I have done suppress the output from the test logs. Could this PR be revised?

@bogdanvlviv To revise the PR, you can rebase your branch against master (git rebase -i master) then force-push your branch back to GitHub (git push -f)

bogdanvlviv · 2016-04-15T23:46:39Z

Could this PR be merged?

jeremy · 2016-04-16T00:11:06Z

activerecord/test/cases/tasks/database_tasks_test.rb

@@ -8,6 +8,9 @@ def setup
      ActiveRecord::Tasks::MySQLDatabaseTasks.stubs(:new).returns @mysql_tasks
      ActiveRecord::Tasks::PostgreSQLDatabaseTasks.stubs(:new).returns @postgresql_tasks
      ActiveRecord::Tasks::SQLiteDatabaseTasks.stubs(:new).returns @sqlite_tasks
+
+      @original_stdout = $stdout
+      $stdout = StringIO.new


Are you setting $stdout back to @original_stdout somewhere (def teardown …)?

No, I am not but it is good idea.

Set $stdout = @original_stdout in teardown to ensure we don't hijack stdout for other tests.

Done!

You can do a one-line multiple assignment to make this a little more concise:

$stdout, @original_stdout = StringIO.new, $stdout

bogdanvlviv · 2016-04-17T18:43:40Z

@jeremy, could we finish this PR?

jeremy · 2016-04-17T19:12:39Z

activerecord/test/cases/tasks/database_tasks_test.rb

+
+    def teardown
+      $stdout = @original_stdout
+      @original_stdout = nil


No need to set this to nil. Just set stdout back to its original value.

bogdanvlviv · 2016-04-17T20:22:30Z

@jeremy, thanks for review! I made changes.

jeremy · 2016-04-17T22:23:37Z

Great work @bogdanvlviv. Thank you for improving this!

bogdanvlviv · 2016-04-18T03:49:48Z

Thanks @jeremy!

arthurnn · 2016-05-05T20:18:20Z

👍

rails-bot assigned pixeltrix Apr 14, 2016

vipulnsward added the railties label Apr 14, 2016

maclover7 reviewed Apr 14, 2016
View reviewed changes

bogdanvlviv force-pushed the notice_for_tasks branch from 2dfd730 to 37856a4 Compare April 14, 2016 18:02

bogdanvlviv changed the title ~~add notice for tasks db:create, db:drop~~ Added notice when database successfully created or dropped. Apr 14, 2016

bogdanvlviv force-pushed the notice_for_tasks branch 2 times, most recently from 9063461 to 5a678b8 Compare April 14, 2016 18:21

vipulnsward added activerecord and removed railties labels Apr 14, 2016

bogdanvlviv force-pushed the notice_for_tasks branch from 5a678b8 to 7e6b0bd Compare April 15, 2016 04:17

jeremy reviewed Apr 15, 2016
View reviewed changes

bogdanvlviv force-pushed the notice_for_tasks branch from 7e6b0bd to 643555f Compare April 15, 2016 04:55

bogdanvlviv force-pushed the notice_for_tasks branch 3 times, most recently from 7a7907b to ddf5198 Compare April 15, 2016 20:17

maclover7 reviewed Apr 15, 2016
View reviewed changes

bogdanvlviv changed the title ~~Added notice when database successfully created or dropped.~~ Added notice when a database is successfully created or dropped. Apr 15, 2016

Edouard-chin reviewed Apr 15, 2016
View reviewed changes

bogdanvlviv force-pushed the notice_for_tasks branch 2 times, most recently from 71ccd78 to 1b2d9c7 Compare April 15, 2016 22:26

jeremy reviewed Apr 16, 2016
View reviewed changes

bogdanvlviv force-pushed the notice_for_tasks branch from 1b2d9c7 to 5abde0b Compare April 16, 2016 00:52

jeremy reviewed Apr 17, 2016
View reviewed changes

Added notice when a database is successfully created or dropped.

2686130

bogdanvlviv force-pushed the notice_for_tasks branch from 5abde0b to 2686130 Compare April 17, 2016 20:12

jeremy merged commit 5154701 into rails:master Apr 17, 2016

bogdanvlviv deleted the notice_for_tasks branch August 15, 2016 13:22

yahonda mentioned this pull request Dec 27, 2016

Suppress Dropped database 'ORCL' messages while running rspec rsim/oracle-enhanced#1103

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added notice when a database is successfully created or dropped. #24551

Added notice when a database is successfully created or dropped. #24551

bogdanvlviv commented Apr 14, 2016 •

edited

rails-bot commented Apr 14, 2016

maclover7 Apr 14, 2016

bogdanvlviv commented Apr 14, 2016 •

edited

maclover7 commented Apr 14, 2016

bogdanvlviv commented Apr 14, 2016 •

edited

jeremy Apr 15, 2016

jeremy commented Apr 15, 2016

bogdanvlviv commented Apr 15, 2016 •

edited

bogdanvlviv commented Apr 15, 2016 •

edited

jeremy commented Apr 15, 2016

bogdanvlviv commented Apr 15, 2016 •

edited

bogdanvlviv commented Apr 15, 2016

maclover7 Apr 15, 2016

Edouard-chin Apr 15, 2016 •

edited

bogdanvlviv Apr 15, 2016 •

edited

jeremy Apr 16, 2016

bogdanvlviv Apr 16, 2016

bogdanvlviv Apr 16, 2016 •

edited

jeremy commented Apr 15, 2016

bogdanvlviv commented Apr 15, 2016

jeremy Apr 16, 2016

bogdanvlviv Apr 16, 2016 •

edited

bogdanvlviv Apr 16, 2016

jeremy Apr 17, 2016

bogdanvlviv commented Apr 17, 2016

jeremy Apr 17, 2016

bogdanvlviv commented Apr 17, 2016

jeremy commented Apr 17, 2016

bogdanvlviv commented Apr 18, 2016

arthurnn commented May 5, 2016

		@@ -4,6 +4,28 @@

		Sean Griffin

		* Added notice when database successfully created or dropped.

Added notice when a database is successfully created or dropped. #24551

Added notice when a database is successfully created or dropped. #24551

Conversation

bogdanvlviv commented Apr 14, 2016 • edited

rails-bot commented Apr 14, 2016

Choose a reason for hiding this comment

bogdanvlviv commented Apr 14, 2016 • edited

maclover7 commented Apr 14, 2016

bogdanvlviv commented Apr 14, 2016 • edited

Choose a reason for hiding this comment

jeremy commented Apr 15, 2016

bogdanvlviv commented Apr 15, 2016 • edited

bogdanvlviv commented Apr 15, 2016 • edited

jeremy commented Apr 15, 2016

bogdanvlviv commented Apr 15, 2016 • edited

bogdanvlviv commented Apr 15, 2016

Choose a reason for hiding this comment

Edouard-chin Apr 15, 2016 • edited

Choose a reason for hiding this comment

bogdanvlviv Apr 15, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bogdanvlviv Apr 16, 2016 • edited

Choose a reason for hiding this comment

jeremy commented Apr 15, 2016

bogdanvlviv commented Apr 15, 2016

Choose a reason for hiding this comment

bogdanvlviv Apr 16, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bogdanvlviv commented Apr 17, 2016

Choose a reason for hiding this comment

bogdanvlviv commented Apr 17, 2016

jeremy commented Apr 17, 2016

bogdanvlviv commented Apr 18, 2016

arthurnn commented May 5, 2016

bogdanvlviv commented Apr 14, 2016 •

edited

bogdanvlviv commented Apr 14, 2016 •

edited

bogdanvlviv commented Apr 14, 2016 •

edited

bogdanvlviv commented Apr 15, 2016 •

edited

bogdanvlviv commented Apr 15, 2016 •

edited

bogdanvlviv commented Apr 15, 2016 •

edited

Edouard-chin Apr 15, 2016 •

edited

bogdanvlviv Apr 15, 2016 •

edited

bogdanvlviv Apr 16, 2016 •

edited

bogdanvlviv Apr 16, 2016 •

edited