Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ActionCable::Connection::ClientSocketTest test #24559

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Fixed ActionCable::Connection::ClientSocketTest test #24559

merged 1 commit into from
Apr 15, 2016
+3 −5

Conversation

vipulnsward
Copy link
Member

  • Fixed ActionCable::Connection::ClientSocketTest that was overriding ActionCable::Connection::StreamTest test name
  • Only add attr_readers for required attributes

@vipulnsward
- Fixed ActionCable::Connection::ClientSocketTest that was overriding…
02a31cf 
… ActionCable::Connection::StreamTest test name

- Only add attr_readers for required attributes
@vipulnsward
Copy link
Member Author

r? @jeremy

@maclover7
Copy link
Contributor

cc @matthewd

@jeremy
Copy link
Member

jeremy commented Apr 15, 2016

Let's keep the separate test and just correct the test class name (omit the second commit)

@vipulnsward
Copy link
Member Author

Ok, done.

@jeremy jeremy merged commit 92182d0 into rails:master Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeremy jeremy

Labels
actioncable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vipulnsward @maclover7 @jeremy @prathamesh-sonpatki