Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of whether or not instead of regardless if ... or not #24656

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Use of whether or not instead of regardless if ... or not #24656

merged 1 commit into from
Apr 20, 2016

Conversation

mohitnatoo
Copy link
Contributor

This is extension of #24639

regardless is usually followed by of and not by if ... or not.

r? @vipulnsward

@rafaelfranca rafaelfranca merged commit fa89202 into rails:master Apr 20, 2016
@mohitnatoo mohitnatoo deleted the regardless-if-or-not branch April 20, 2016 18:37
@maclover7
Copy link
Contributor

@mohitnatoo Please try to comment on existing pull requests, rather than creating new ones with similar changes 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vipulnsward vipulnsward

Labels
activemodel docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mohitnatoo @maclover7 @rafaelfranca @vipulnsward