Add #18323 to 5.0 release notes #24657
Conversation
| @@ -227,6 +227,10 @@ Please refer to the [Changelog][action-pack] for detailed changes. | |||
| `RedirectBackError`. | |||
| ([Pull Request](https://github.com/rails/rails/pull/22506)) | |||
|
|
|||
| * `ActionDispatch::IntegrationTest` and | |||
| `ActionController::TestCase` accept keyword arguments instead of | |||
| positional arguments. ([Pull Request](https://github.com/rails/rails/pull/18323)) | |||
There was a problem hiding this comment.
What's off about the alignment here? MacVim seems to be trying to imitate the alignment of the file, and appears to render ok on GitHub, as well:
There was a problem hiding this comment.
accept is putting it lightly. Positional args were deprecated in favor of kw args.
Perhaps we shouldn't mention ActionController::TestCase because that's soft deprecated.
Another thing to think about: why force people to upgrade a dead end?
There was a problem hiding this comment.
Alignment is off because positional word is not aligned with ActionDispatch. See the lines above
| @@ -227,6 +227,9 @@ Please refer to the [Changelog][action-pack] for detailed changes. | |||
| `RedirectBackError`. | |||
| ([Pull Request](https://github.com/rails/rails/pull/22506)) | |||
|
|
|||
| * `ActionDispatch::IntegrationTest` and `ActionController::TestCase` deprecate positional arguments in favor of | |||
| positional arguments. ([Pull Request](https://github.com/rails/rails/pull/18323)) | |||
There was a problem hiding this comment.
I'm glad we deprecated positional arguments in favor of positional arguments. Positional arguments are much nicer to use than positional arguments. 
There was a problem hiding this comment.
My wife thinks I'm funny. That's all that matters.
Fixes rails#23643. [ci skip]
Fixes #23643 -- should we add a link to this issue for future reference?
[ci skip]