Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in 'Ruby on Rails 3.0 Release Notes' [ci skip] #24686

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Fix broken links in 'Ruby on Rails 3.0 Release Notes' [ci skip] #24686

merged 1 commit into from
Apr 22, 2016

Conversation

javiervidal
Copy link
Contributor

The link to https://blog.engineyard.com/2010/render-options-in-rails-3/ is broken. The link has been replaced with the correct one in the Engine Yard blog.

The link to http://caffeinedd.com/guides/331-making-generators-for-rails-3-with-thor is broken. The content in this domain is not longer available. I have found the content of this domain neither in archive.org nor in any other domain, so I have deleted the link.

I have update the link of the bundler repository from https://github.com/carlhuda/bundler to https://github.com/bundler/bundler.

@rails-bot
Copy link

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

@@ -250,7 +249,7 @@ Deprecations:

More Information:

* [Render Options in Rails 3](http://www.engineyard.com/blog/2010/render-options-in-rails-3/)
* [Render Options in Rails 3](https://blog.engineyard.com/2010/render-options-in-rails-3/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this gives 404 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you need to remove the / in the end. Can you fix that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Done.

@vipulnsward vipulnsward merged commit aa804b1 into rails:master Apr 22, 2016
@vipulnsward
Copy link
Member

Thanks @javiervidal !

@javiervidal javiervidal deleted the broken-links-in-3-0-releases-notes branch April 22, 2016 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants