remove unnessary option setting from test runner #24696
Conversation
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
|
|
||
| assert_match '1 runs, 1 assertions', output | ||
| assert_match 'Execute test', output | ||
| end |
There was a problem hiding this comment.
Can we add test from #24372 to accompany this?
There was a problem hiding this comment.
You mean add a test using --rakefile option?
If so, I've added a test.
|
Nice fix. This does work for me now: But doesn't. We can probably check and include a fix for that here. |
y-yagi
force-pushed
the
remove_unnessary_option_setting
branch
from
dacb714
to
1c52de9
Compare
|
Thank you for pointing it out! Also fixed |
| @@ -19,6 +19,9 @@ task routes: :environment do | |||
|
|
|||
| OptionParser.new do |opts| | |||
| opts.banner = "Usage: rails routes [options]" | |||
|
|
|||
| Rake.application.standard_rake_options.each { |args| opts.on(*args) } | |||
There was a problem hiding this comment.
This is iffy. We'd likely need to swallow rake options for every Rails command with custom option parsing.
There was a problem hiding this comment.
Hmm, come to think of it there might not be other cases since routes and test are the only rake tasks we fiddled with in Rails 5. So this feels like an ok compromise 👍
If run the test over the `rake` command, because of the test patterns is passed via `rake_run` method, do not need to be obtained from the argv. This probably fixes rails#24372.
In order to prevent `OptionParser::ParseError` when specify the rake options to `routes` task.
y-yagi
force-pushed
the
remove_unnessary_option_setting
branch
from
1c52de9
to
996092e
Compare
|
❤️ |
|
😄 |
If run the test over the
rakecommand, because of the test patterns is passedvia
rake_runmethod, do not need to be obtained from the argv.This probably fixes #24372.