Active Model: Improve CHANGELOG and documentation for validates_acceptance_of [ci skip]
#24799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| In the past, only "1" was the default and you were required to add | ||
| accept: true. | ||
| The default for `validates_acceptance_of` is now `"1"` and `true`. | ||
| In the past, only `"1"` was the default and you were required to pass |
There was a problem hiding this comment.
Thanks Vipul, Any specific reasons for Previously over In the past?
There was a problem hiding this comment.
In the past implies a change that existed some time ago, and not just the one we are just changing.
I think it's used only at one place(change) that's just below in the changelog. Everywhere else we use previously.
prathamesh-sonpatki
force-pushed
the
18439-followup
branch
from
b8135df
to
94e0921
Compare
|
r? @jeremy |
| ``` | ||
|
|
||
| It can also receive an `:accept` option, which determines the allowed values | ||
| that will be considered accepted. It defaults to `['1', true]` and can be |
…ptance_of` [ci skip] - Improve CHANGELOG entry for rails#18439. - The documentation is updated as per changes in PR rails#18439 to the `accept` option. - The explanation about the virtual attribute is moved at the end so that the arity of `accept` option is explained first. - Added a note that `message` can also be passed to `validates_acceptance_of`.
prathamesh-sonpatki
force-pushed
the
18439-followup
branch
from
94e0921
to
f7d7147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
acceptoption.that the arity of
acceptoption is explained first.messagecan also be passed tovalidates_acceptance_of.