Pass over Action Cable docs #24850
Merged
Pass over Action Cable docs #24850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maclover7
force-pushed
the
jm-actioncable-docs
branch
from
2697883
to
f3e912a
Compare
| # | ||
| # Using Active Record, Redis, etc within your channel actions means you'll get a separate connection from each thread in the worker pool. | ||
| # Plan your deployment accordingly: 5 servers each running 5 Puma workers each running an 8-thread worker pool means at least 200 database | ||
| # connections. | ||
| # | ||
| # Also, ensure that your database connection pool size is as least as large as your worker pool size. Otherwise, workers may oversubscribe | ||
| # the db connection pool and block while they wait for other workers to release their connections. Use a smaller worker pool or a larger | ||
| # db connection pool instead. | ||
| # the datbase connection pool and block while they wait for other workers to release their connections. Use a smaller worker pool or a larger |
There was a problem hiding this comment.
Dat base are belong to us ( ͡° ͜ʖ ͡°)
There was a problem hiding this comment.
There's still a typo here ;)
maclover7
force-pushed
the
jm-actioncable-docs
branch
from
f3e912a
to
a3008f4
Compare
|
Otherwise 👍 |
[ci skip]
maclover7
force-pushed
the
jm-actioncable-docs
branch
from
a3008f4
to
c420bed
Compare
|
👍 thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]