Fix has_one enum where queries
#25146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maclover7
force-pushed
the
fix-25128
branch
2 times, most recently
from
5aa3ba7
to
da2a474
Compare
| if association && !association.polymorphic? | ||
| association_klass = association.klass | ||
| arel_table = association_klass.arel_table.alias(table_name) | ||
| # First check what is passed in, and see if an associationexists in |
There was a problem hiding this comment.
need a space here: associationexists.
| @@ -44,17 +44,21 @@ def associated_with?(association_name) | |||
| def associated_table(table_name) | |||
| return self if table_name == arel_table.name | |||
|
|
|||
| association = klass._reflect_on_association(table_name) | |||
There was a problem hiding this comment.
Seems like this entire PR could be simplified to just changing this line to
association = klass._reflect_on_association(table_name) || klass._reflect_on_association(table_name.singularize)
maclover7
force-pushed
the
fix-25128
branch
2 times, most recently
from
b1560d5
to
a47794e
Compare
|
👍 updated @sgrif |
| if association && !association.polymorphic? | ||
| association_klass = association.klass | ||
| arel_table = association_klass.arel_table.alias(table_name) | ||
| arel_table = association_klass.arel_table.alias(table_name.to_s.pluralize) |
|
👍 updated again @sgrif :) |
|
👍 |
kamipo
pushed a commit
to kamipo/rails
that referenced
this pull request
Jul 28, 2016
Fix `has_one` `enum` `where` queries
rafaelfranca
added a commit
that referenced
this pull request
Jul 28, 2016
Backport #25146 to 5-0-stable
This was referenced Jan 7, 2017
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
Jan 9, 2017
In the following: rails/rails#25146 Rails added a regression to making nested joins with references to those joins in the WHERE clause, and this causes an error when running this test suite in Rails 5.0.1. This has been addressed in Rails with: rails/rails#27598 And has been merged into master, but it is likely that Rails 5.0.1 will not be pulled from Rubygems, and the ManageIQ will fail to run tests properly with that version of Rails. Because of that, and to allow the tests to function in the same way, the simplest thing to do is to stringify the keys manually avoid the error for now. This is against the convention (most Rails devs prefer symbols), but this allows the tests to remain as they were.
chrisarcand
pushed a commit
to chrisarcand/manageiq
that referenced
this pull request
Jan 9, 2017
In the following: rails/rails#25146 Rails added a regression to making nested joins with references to those joins in the WHERE clause, and this causes an error when running this test suite in Rails 5.0.1. This has been addressed in Rails with: rails/rails#27598 And has been merged into master, but it is likely that Rails 5.0.1 will not be pulled from Rubygems, and the ManageIQ will fail to run tests properly with that version of Rails. Because of that, and to allow the tests to function in the same way, the simplest thing to do is to stringify the keys manually avoid the error for now. This is against the convention (most Rails devs prefer symbols), but this allows the tests to remain as they were.
agrare
pushed a commit
to ManageIQ/inventory_refresh
that referenced
this pull request
Aug 28, 2018
In the following: rails/rails#25146 Rails added a regression to making nested joins with references to those joins in the WHERE clause, and this causes an error when running this test suite in Rails 5.0.1. This has been addressed in Rails with: rails/rails#27598 And has been merged into master, but it is likely that Rails 5.0.1 will not be pulled from Rubygems, and the ManageIQ will fail to run tests properly with that version of Rails. Because of that, and to allow the tests to function in the same way, the simplest thing to do is to stringify the keys manually avoid the error for now. This is against the convention (most Rails devs prefer symbols), but this allows the tests to remain as they were. (transferred from ManageIQ/manageiq@4e96ee4)
agrare
pushed a commit
to ManageIQ/inventory_refresh
that referenced
this pull request
Sep 5, 2018
In the following: rails/rails#25146 Rails added a regression to making nested joins with references to those joins in the WHERE clause, and this causes an error when running this test suite in Rails 5.0.1. This has been addressed in Rails with: rails/rails#27598 And has been merged into master, but it is likely that Rails 5.0.1 will not be pulled from Rubygems, and the ManageIQ will fail to run tests properly with that version of Rails. Because of that, and to allow the tests to function in the same way, the simplest thing to do is to stringify the keys manually avoid the error for now. This is against the convention (most Rails devs prefer symbols), but this allows the tests to remain as they were. (transferred from ManageIQ/manageiq@4e96ee4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25128