Fix bug with symbolized keys in .where with nested join (alternative to #27598) #27599
Conversation
This will cause a failure with the changes from 8e2e5f9: rails@8e2e5f9 With the `singularize` call that is being done in that method when there is multiple nestings of associations (JOIN calling a JOIN) and the `stringify_keys!` is only called once here: https://github.com/rails/rails/blob/21e5fd4/activerecord/lib/active_record/relation/where_clause_factory.rb#L16 And not in the subsequent recursion in `.predicate_builder`
Since it is expected that top level keys are in their string form, not symbol, make sure that keys on all levels are now strings so that subsequent methods that expect only strings for keys always get them.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
cc: @maclover7 (since you were involved with #25146 ) |
Summary
In #25146, code was added to fix making where clauses against tables with an
enumcolumn with ajoinpresent as part of the query. As part of this fix, it calledsingularizeon thetable_namevariable that was passed into theassociated_tablemethod.table_name, in some circumstances, can also be a symbol if more than one level of joins exists in the Relation (i.ejoins(:book => :subscription)). This fixes that by adding chaning the.stringify_keys!(found inActiveRecord::Relation::WhereClauseFactory) to be a.deep_stringify_keys!to stringfy keys at all levels.Other Information
This bug only surfaces when a join is made more than 1 level deep since the
where_clause_buildercallsstringify_keys!on the top level of the.wherehash:https://github.com/rails/rails/blob/21e5fd4/activerecord/lib/active_record/relation/where_clause_factory.rb#L16
So this hides this edge case from showing up in the test suite with the current coverage and the test that was in PR #25146.
This is the alternative to #27598 in which the change from PR #25146 was fixed in isolation. Instead, here we fix the false assumption that all
table_namevalues being passed into.associated_tableare a string. This might have wider effects because of that, so that should be considered when reviewing.