Calling request.params in routing constraints cannot interfere with subsequent routes. [Closes #2510]
#2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you call 'request.params' in a constraint matcher, subsequent routes don't have their path attributes set correctly. In this case, a URL of '/about' would have params[:something] == 'about' in the route match ':id' Adding this constraint and route causes the following test to fail. 1) Failure: test_default_params(TestRoutingMapper) [/Users/joevandyk/projects/rails/actionpack/test/dispatch/routing_test.rb:1475]: <"home"> expected but was <nil>.
… subsequent routes. [Closes rails#2510] As the same request is reused thru all the routing constraints, accessing a memoized form of `params` would prevent the router from redefining it with a new set of parameters (the current route parameters).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the same request is reused thru all the routing constraints,
accessing a memoized form of
paramswould prevent the router fromredefining it with a new set of parameters (the current route
parameters).
Another solution could be to
duptheenvhere, but I' not sure this is a good idea in terms of memory.