[ci skip] define_model_callbacks only exist in active model

[Edouard-chin]

Small documentation fix

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Edouard-chin]

I'm wondering if it would be worth mentioning in the docs that calling define_callbacks twice will actually remove the callbacks already set as it's creating a new instance of CallbackChain

define_callbacks :validate

set_callback :validate, ->(o) { o.returns_true }
define_callbacks :validate # This removes the previous callback we set

[maclover7]

^ Do you want to submit that as a separate PR for that?

[Edouard-chin]

If you think it's valuable then I can add it in this PR. I ran into the problem, having a line in the doc mentioning it would have probably saved me a headache 😅

Edit: Added an entry in the doc. Will remove commit if you dislike it

[maclover7]

previous callback --> previous callbacks
set --> registered (since we using set_ two words down the line 😉)

[maclover7]

Seems reasonable to me. Added a comment with one or two small grammar changes :)

[Edouard-chin]

thanks for your help 😸

[vipulnsward]

Did you follow this from somewhere?

[Edouard-chin]

yes, https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/metal/http_authentication.rb#L161

I just added 2 more = to be consistent with the ===== Option above

[vipulnsward]

Thanks @Edouard-chin !