Point to the correct documentation #25696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The options used in this file are *not* directly described in the Rails 5.0 release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but instead in section 2 of the Guide for Upgrading Ruby on Rails document (http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
|
Thanks @bquorning! I think we can backport directly to 5-0-stable the merge commit without going through PR. That's how we have been doing it for other commits which need to be backported. @kaspth can do that :) I can't directly push to 5-0-stable, so tagging this with |
|
This should not have |
|
My bad. @kaspth let me know if we should revert it. |
Oops, you’re right. It does, however, only change a comment. I’ll be more careful with the |
kaspth
pushed a commit
to kaspth/rails
that referenced
this pull request
Jul 5, 2016
…entation Point to the correct documentation
|
@prathamesh-sonpatki only owners can push to 5-0-stable, so it's fine to create a backport PR, which I've done in #25705. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options used in this file are not directly described in the Rails 5.0 release notes, but instead in section 2 of the Guide for Upgrading Ruby on Rails document.
cc/ @prathamesh-sonpatki @kaspth
Should I open a PR for backporting to 5-0-0-stable?