Fix keyed defaults with root #25913
Fix keyed defaults with root #25913
Conversation
The merging of the 'defaults' option was moved up the stack in e852daa This allows us to see where these options originate from the standard HttpHelpers (get, post, patch, put, delete) Unfortunately this move didn't incorporate the 'root' method, which has always allowed the same 'defaults' option before.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
👍 Thank you for finding and submitting a PR to fix! Action Pack tests are passing here, but build is failing due to a Sprockets issue which should be resolved shortly. |
chrisarcand
force-pushed
the
fix-keyed-defaults-with-root
branch
from
9ce3519
to
7b7ce2b
Compare
|
Tests are 💚 again. EDIT: Er...looked green, looks like only Code Climate ran. Travis is having some big issues today. |
chrisarcand
force-pushed
the
fix-keyed-defaults-with-root
branch
from
7b7ce2b
to
d61a2bd
Compare
chrisarcand
force-pushed
the
fix-keyed-defaults-with-root
branch
from
d61a2bd
to
2a946da
Compare
|
Whew. Finally ready for a look, @rafaelfranca |
|
Backported in ec07105 |
Fix keyed defaults with root
Fix keyed defaults with root
|
❤️ |
Summary
The merging of the 'defaults' option was moved up the stack in e852daa. This allows us to see where these options originate from the standard
HttpHelpers(get,post,patch,put,delete)Unfortunately this move didn't incorporate the 'root' method, which has always allowed the same 'defaults' option.
In short, these routes should be the same (Tested in Rails 3.2, 4.2, 5.0)
My thanks to @jrafanie for helping bisect this issue and find the regression!