Clarify expires_now documentation #26016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
| # Sets an HTTP 1.1 Cache-Control header of <tt>no-cache</tt> so no caching should | ||
| # occur by the browser or intermediate caches (like caching proxy servers). | ||
| # Sets an HTTP 1.1 Cache-Control header of <tt>no-cache</tt>. This means the | ||
| # asset will always be marked as stale, so clients must always revalidate. |
There was a problem hiding this comment.
Can you drop the initial 'always'.
.. the asset with be marked as stale, so clients ...
There was a problem hiding this comment.
I'd replace asset with resource, and keep the initial 'always' for emphasis.
[ci skip]
nateberkopec
force-pushed
the
patch-1
branch
from
b19a022
to
0d1deb3
Compare
|
Updated, I ended up agreeing with both @vijaydev and @vipulnsward. |
|
Thanks @nateberkopec ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed my mind about #19556 to @matthewd's position. For those unfamiliar with HTTP caching, the docs (and the value set in the method) could be confusing.
#19556 brought up that the documentation for expires_now is somewhat confusing. In most caching contexts (like in Rails fragment caching), saying you're "not caching" something means that the value is not stored anywhere and must be recalculated every time. This is not how it works in HTTP, so a method that sets "no_cache" may be misread as "don't allow the client or intermediate caches to store this value." This change makes that explicit, so no one accidentally uses
expire_nowto try to prevent sensitive information from being cached.