Improve #tag_option performance

[badosu]

After running stackprof on my production application homepage I noticed that TagHelper#tag_option is the second occurrence:

  Mode: wall(50)
  Samples: 43496 (2.11% miss rate)
  GC: 713 (1.64%)
==================================
     TOTAL    (pct)     SAMPLES    (pct)     FRAME
      2459   (5.7%)        2459   (5.7%)     ActiveSupport::SafeBuffer#initialize
      3273   (7.5%)        1810   (4.2%)     ActionView::Helpers::TagHelper#tag_option
      2177   (5.0%)        1754   (4.0%)     #<Module:0x0055667655fe60>.unwrapped_html_escape
      1746   (4.0%)        1746   (4.0%)     ThreadSafe::NonConcurrentCacheBackend#[]
       889   (2.0%)         889   (2.0%)     ActiveSupport::Notifications::Event#initialize

I performed some tests with benchmark-ips and noticed that String#gsub with a String input is almost 2x faster than with a Regex (in this specific case).

I also benchmarked this change and #tag_option speed is improved from 20-45% on the most common cases (when escape is true, with or without quotes present) and up to 50% when escape is false.

I noticed as well that by freezing the string literals I was able to extract a little bit more of performance when an array of values is passed.

Given that this is an internal method and the diff is very trivial I can't see any reason not to change this and have a little performance improvement for free.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[badosu]

I am not sure why the build failed but seems unrelated with this PR.

[badosu]

@rafaelfranca Thanks!

[rafaelfranca]

Backported in 1f38ef0 and 2509b24