Improve 5.0 Release notes #26259
Improve 5.0 Release notes #26259
Conversation
- Remove Duplicated explanation. - Fix some typo. - Attach PR, commit link that missed one.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| @@ -212,7 +212,7 @@ Please refer to the [Changelog][railties] for detailed changes. | |||
| ([Pull Request](https://github.com/rails/rails/pull/22173)) | |||
|
|
|||
| * Deprecated the tasks in the `rails` task namespace in favor of the `app` namespace. | |||
| (e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.) | |||
| (e.g. `rails:update` and `rails:template` is renamed to `app:update` and `app:template`.) | |||
There was a problem hiding this comment.
I think it's more natural... If you don't agree, I will revert this :)
There was a problem hiding this comment.
We are referring to two entities, so are is apt here.
There was a problem hiding this comment.
ok, I will apply 👍
|
Rest looks good. @riseshia thanks for the change. |
Improve 5.0 Release notes
Summary
Thanks for reading this. and Have a nice day XD