Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix document for radio_button #26354

Merged
merged 1 commit into from
Sep 1, 2016
Merged

fix document for radio_button #26354

merged 1 commit into from
Sep 1, 2016

Conversation

shingo-nakanishi
Copy link
Contributor

  • Add # Let's say that @user.receive_newsletter returns "no": for def radio_button(object_name, method, tag_value, options = {}).
  • Fix # Let's say that @user.category returns "no": to # Let's say that @user.receive_newsletter returns "no":

add `# Let's say that @user.receive_newsletter returns "no":` for `def radio_button(object_name, method, tag_value, options = {})`.
fix `# Let's say that @user.category returns "no":` to `# Let's say that @user.receive_newsletter returns "no":`
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@vipulnsward vipulnsward merged commit 897ac0e into rails:master Sep 1, 2016
@vipulnsward
Copy link
Member

Thanks!

@shingo-nakanishi please add a [ci skip] to document-only changes, so that we can avoid running builds on Travis CI for doc changes.

@shingo-nakanishi
Copy link
Contributor Author

@vipulnsward Thank you! I will add a [ci skip] to document-only changes, next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants