remove useless rescue #2647
Merged
remove useless rescue #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rescue NoMethodError | ||
| false | ||
| end || Rails.application.config.assets.debug | ||
| params[:debug_assets] == '1' || params[:debug_assets] == 'true' || Rails.application.config.assets.debug |
There was a problem hiding this comment.
Can you split this line up? Or perhaps use a more concise version, e.g.:
%w(1 true).include?(params[:debug_assets]) || Rails.application.config.assets.debugThere was a problem hiding this comment.
Yup, that's something I can do. I don't like the %w format though (that's a very personal opinion) though.
There was a problem hiding this comment.
['1', 'true'] is still an improvement. I'm on a crusade against long lines in Rails these days.
|
I prefer the first version is more readable and faster you can split the lines anyway ... |
params is a method, defined in every controller, which always returns a hash. If it raises a NoMethodError, it means there's a bug somewhere else, which we want to know about.
|
I've changed it. Thank you for your opinion :) |
spastorino
added a commit
that referenced
this pull request
Aug 30, 2011
This reverts commit 125b1b0.
spastorino
added a commit
that referenced
this pull request
Aug 30, 2011
This reverts commit 125b1b0.
spastorino
added a commit
that referenced
this pull request
Aug 30, 2011
This reverts commit 125b1b0.
tenderlove
added a commit
that referenced
this pull request
Aug 31, 2011
* 3-1-0: bumping to 3.1.0 Bump sprockets up Depend on sass-rails and coffee-rails 3.1.0 Revert "Merge pull request #2647 from dmathieu/no_rescue" Merge pull request #2756 from guilleiguaran/manifest-location Merge pull request #2748 from guilleiguaran/assets-version-config adds the asset pipeline guide to the index incorporate feedback from vijaydev and dasch to rephrase this to sound more natural, and some grammar fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
params is a method, defined in every controller, which always returns a hash.
If it raises a NoMethodError, it means there's a bug somewhere else, which we want to know about.