adds delegetion for eof? to AD::Http::UploadedFile #2664
Conversation
|
|
||
| def eof? | ||
| @tempfile.eof? | ||
| end |
There was a problem hiding this comment.
How about delegate :eof?, :to => :@tempfile?
There was a problem hiding this comment.
I thought about that, but it would be different than #open, #path, #read, #rewind, and #size. I didn't want to change the whole class.
There was a problem hiding this comment.
Then it's fine - local consistency is the most important.
|
I'm running into this too, any chance of pulling in this change? |
|
@jigfox hey, could you please bring this up-to-date with current master? I guess it'd possible to merge then, thanks. |
if you want to read the file you may need to ask if there is something to read from
|
@carlosantoniodasilva I updated the code for the current master, it would be great if this can be merged |
|
@jigfox ok cool, I'll ping someone to double-check and merge. Thanks. |
|
This is already present since Rails 4.0.0. Thank you for the pull request. |
if you want to read the file you may need to ask if there is something
to read from