fix with_routing test helper to make it work with api-only controllers

[yukideluxe]

Hi again! 👋

I found another regression while migrating my api-only app to Rails 5 (I'm on fire 🔥) The with_routing test helper doesn't work for controllers that inherit from ActionController::API because the ActionView::Rendering module is not longer included as it was in the rails-api gem https://github.com/rails-api/rails-api/blob/master/lib/rails-api/action_controller/api.rb#L128

Hope you like the fix! ❤️

[maclover7]

Build failures are unrelated to this PR.

[kaspth]

Thanks again for the 🔥, @yukideluxe

@spastorino you're the API person, what do you think of the fix?

[kaspth]

Alternatively, I think we could skip the ApiOnlyController class with: @controller = Class.new(ActionController::Api).new

[spastorino]

Cool thanks for your work @ yukideluxe.

@kaspth seems OK to me at least for now. Maybe at some point in several places we could structure the code a bit differently. Perhaps in a lot of cases for API only we could have classes or modules with the basic functionality and for regular controllers we could reuse that code and enhance in subclasses or with extra modules or something like that I think would be better than having a lot of if statements.

[yukideluxe]

Thanks for the feedback! @kaspth I've updated the test with your suggestion ✌️

[spastorino]

I'd add a process and assert like what we do here https://github.com/yukideluxe/rails/blob/8e9c8a19afc3f41b5bb9596ad604c7f386a903d0/actionpack/test/controller/action_pack_assertions_test.rb#L220

[yukideluxe]

Hi! I've changed the test so it does the same as the one you put as example :)
I didn't do the assertion before because the test was failing by just using with_routing

[kaspth]

@spastorino yup, agreed about the future improvements.

@yukideluxe looks good! Can you squash your commits and add an entry in the Action Pack changelog? 😁

[yukideluxe]

@kaspth done! 💪 🎉 ❤️

[kaspth]

@yukideluxe BOOM! 🎩❤️💪

Backported to 5-0-stable: c484e21