Preserve up and down return type
#27596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 4.2 calling `ActiveRecord::Migrator.migrate` would return an array of results. Without realizing that this return type was expected I accidentally introduced a change in rails@4d60e93 This PR preserves the previous behavior and adds a test on the return type. This will need a backport to 5.0 branch.
maclover7
approved these changes
Jan 6, 2017
rafaelfranca
approved these changes
Jan 6, 2017
prathamesh-sonpatki
added a commit
to prathamesh-sonpatki/rails
that referenced
this pull request
Jan 7, 2017
- rails#27596 Updated "run" and "migrate" method for returning correct value but only added test for "migrate" method. This commit adds a test for "run" as well.
spastorino
added a commit
that referenced
this pull request
Jan 8, 2017
Followup of #27596, test output of "run" method as well
schneems
pushed a commit
to schneems/rails
that referenced
this pull request
Jan 9, 2017
- rails#27596 Updated "run" and "migrate" method for returning correct value but only added test for "migrate" method. This commit adds a test for "run" as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 4.2 calling
ActiveRecord::Migrator.migratewould return an array of results. Without realizing that this return type was expected I accidentally introduced a change in 4d60e93This PR preserves the previous behavior and adds a test on the return type. This will need a backport to 5.0 branch.