Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActionCable guide to better describe SubscriptionAdapter config #27719

Merged
merged 1 commit into from Jan 18, 2017

Conversation

matrix9180
Copy link
Contributor

@matrix9180 matrix9180 commented Jan 18, 2017

Summary

Fleshed out documentation on each SubscriptionAdapter including new channel_prefix support on the redis/evented_redis adapters (#27425).

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit b19c221 into rails:master Jan 18, 2017
@matrix9180 matrix9180 changed the title [WIP] Update ActionCable guide to better describe SubscriptionAdapter config Update ActionCable guide to better describe SubscriptionAdapter config Jan 18, 2017
maclover7 added a commit to maclover7/rails that referenced this pull request Jan 18, 2017
@maclover7
Copy link
Contributor

Made some style + grammar changes to this in #27731.

maclover7 added a commit that referenced this pull request Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants