assets:precompile should not append asset digests when config.assets.digest is false

[spohlenz]

See my comment on #2768.

Basically, given that config.assets.digest can be set to false in production mode, rake assets:precompile should respect this configuration and not append asset digests to the filenames when set to false.

[rhulse]

Sorry, but allowing compilation without digests would be a Bad Thing. Unless I am missing something, this is not something that should ever be switched off in production.

:-)

It is assumed that you will have far-future headers set for files compiled to /assets. If you do not have digests on then it is impossible to get remote clients to refetch the assets. If you precompile without digests then you should not have far-future headers set, which kind of negates the whole point of the feature, IMHO.

[spohlenz]

Agree to an extent, but config.assets.digest has been added as a config option (see production.rb), and this option is useless (and will break assets) if assets:precompile does not respect it.

I still need to fix/add some tests for this.

[rhulse]

Sure, yes it does break in that case. It just doesn't make sense to turn it off :-)

[josevalim]

I believe we should respect the user configuration, regardless if it makes sense or not. +1 for this pull request. @spohlenz, could you please rebase it? After you rebase it, please ping/mention me.

[spohlenz]

Squashed and rebased. Thanks @josevalim.

[josevalim]

/cc @spastorino @guilleiguaran

[guilleiguaran]

@josevalim, agree. I discourage do it but is a user choice. +1

[josevalim]

Merged, can we have the same for master?