Make content_tag_for and div_for accepts the array of records
#2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +17,19 @@ module ActionView | |||
| # | |||
| # <div id="person_123" class="person foo"> Joe Bloggs </div> | |||
| # | |||
| # You can also passed an array of Active Record objects, which will then | |||
|
@vijaydev pull request updated as requested. |
|
@josevalim bro, can I have a review of this commit? |
| options.merge!({ :class => "#{dom_class(record, prefix)} #{options[:class]}".strip, :id => dom_id(record, prefix) }) | ||
| content_tag(tag_name, options, &block) | ||
| if record.respond_to?(:to_ary) | ||
| record.map do |single_record| |
There was a problem hiding this comment.
Shouldn't this be record.to_ary.map ? I don't think implementing to_ary means it implements all Enumerable methods.
There was a problem hiding this comment.
Yep, I totally agree on this one.
So instead of having to do this:
@items.each do |item|
content_tag_for(:li, item) do
Title: <%= item.title %>
end
end
You can now do this:
content_tag_for(:li, @Items) do |item|
Title: <%= item.title %>
end
|
@josevalim pull request updated. I think it's better to change the method signature a bit too, to make sure what to expected from the variable. |
josevalim
added a commit
that referenced
this pull request
Sep 4, 2011
Make `content_tag_for` and `div_for` accepts the array of records
|
Perfect pull request: docs + code + tests. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So instead of having to do this:
You can now do this:
(Same goes for the
div_for)