Fix LogSubscriber to allow legacy binds
#28526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
force-pushed
the
fix_log_subscriber_to_allow_legacy_binds
branch
from
f72a168
to
258842c
Compare
| @@ -44,17 +44,17 @@ def sql(event) | |||
| private | |||
|
|
|||
| def type_casted_binds(binds, casted_binds) | |||
| casted_binds || binds.map { |attr| type_cast attr.value_for_database } | |||
| casted_binds || ActiveRecord::Base.connection.send(:type_casted_binds, binds) | |||
There was a problem hiding this comment.
Can we make this method public but private API? We prefer to avoid using send inside the framework.
Follow up of rails#27939.
kamipo
force-pushed
the
fix_log_subscriber_to_allow_legacy_binds
branch
from
258842c
to
53f8716
Compare
kamipo
commented
Mar 22, 2017
| else | ||
| binds.map { |attr| type_cast(attr.value_for_database) } | ||
| end | ||
| def type_casted_binds(binds) # :nodoc: |
There was a problem hiding this comment.
I made this method to public.
|
Backported in a59d0ee |
rafaelfranca
added a commit
that referenced
this pull request
Mar 22, 2017
…acy_binds Fix `LogSubscriber` to allow legacy `binds`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #27939.
r? @rafaelfranca