5-0-stable: Fix select_all with legacy binds
#28495
Conversation
Because `type_cast` against `binds` always requires `attr.value_for_database` and this pattern appears frequently.
|
|
| if binds.first.is_a?(Array) | ||
| binds.map { |column, value| type_cast(value, column) } | ||
| else | ||
| binds.map { |attr| type_cast(attr.value_for_database) } |
There was a problem hiding this comment.
We have a method above: prepare_binds_for_database that does exactly what this does.
There was a problem hiding this comment.
Since 5.0, binds that generated in the internal is an array of QueryAttribute.
This fix only addresses passing legacy binds explictly case (e.g. conn.select_all("...", nil, [[column, value], ...])) and it is sufficient fix I think.
There was a problem hiding this comment.
yeah, I mean that we can reuse that method here.
|
hmm... we also need to pick f814585. |
| end | ||
| def render_bind(attr, type_casted_value) | ||
| value = if attr.type.binary? && attr.value | ||
| "<#{attr.value_for_database.to_s.bytesize} bytes of binary data>" |
There was a problem hiding this comment.
I realized an issue. We cannot render legacy binds even if master branch.
If passed legacy binds, attr is an array, cannot call attr.type.binary?.
There was a problem hiding this comment.
Yeah, we will need an conditional here.
Follow up of rails#27939.
|
Added #28526. |
|
Any chance this fix could be merged in 5-0-stable? This has already been fixed in 5-1-stable. |
Backport #27939.
r? @rafaelfranca