Mixin CollectionProxy::DelegateExtending after ClassSpecificRelation
#28828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ClassSpecificRelation` has `method_missing` and the `method_missing` is called first. if an associated class has the missing method in a relation, never reach to the `method_missing` in the `CollectionProxy`. I extracted `DelegateExtending` and included it to the delegate class that including `ClassSpecificRelation` to fix the issue. Fixes rails#28246 (comment).
kamipo
force-pushed
the
fix_extending_modules_on_association
branch
from
f515b7f
to
22fa48f
Compare
rafaelfranca
added a commit
that referenced
this pull request
Apr 26, 2017
…ation Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`
rafaelfranca
added a commit
that referenced
this pull request
Apr 26, 2017
…ation Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`
rafaelfranca
added a commit
that referenced
this pull request
May 15, 2017
…n_association" This reverts commit 69c49f1. Revert "Revert "Revert "Merge pull request #28246 from pwim/backport_delegate_to_scope_rather_than_merge""" This reverts commit 7dba3f1. See #28246 (comment) for the reason.
rafaelfranca
added a commit
that referenced
this pull request
May 15, 2017
…odules_on_association"" This reverts commit d6679af. We already released this commit so we can't just revert anymore.
rafaelfranca
added a commit
to rafaelfranca/omg-rails
that referenced
this pull request
May 15, 2017
…x_extending_modules_on_association""" This reverts commit 9d7f526.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassSpecificRelationhasmethod_missingand themethod_missingiscalled first. if an associated class has the missing method in a
relation, never reach to the
method_missingin theCollectionProxy.I extracted
DelegateExtendingand included it to the delegate classthat including
ClassSpecificRelationto fix the issue.Fixes #28246 (comment).