Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixin CollectionProxy::DelegateExtending after ClassSpecificRelation #28828

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Mixin CollectionProxy::DelegateExtending after ClassSpecificRelation #28828

merged 1 commit into from
Apr 26, 2017

Commits on Apr 22, 2017

  1. Mixin CollectionProxy::DelegateExtending after ClassSpecificRelation 

    `ClassSpecificRelation` has `method_missing` and the `method_missing` is
called first. if an associated class has the missing method in a
relation, never reach to the `method_missing` in the `CollectionProxy`.
I extracted `DelegateExtending` and included it to the delegate class
that including `ClassSpecificRelation` to fix the issue.

Fixes rails#28246 (comment).
    @kamipo
    kamipo committed Apr 22, 2017
    Configuration menu
    Copy the full SHA
    22fa48f View commit details
    Browse the repository at this point in the history