Add type caster to `RuntimeReflection#alias_name` #28961

maclover7 · 2017-05-02T19:54:29Z

Summary

Since we have been using this Arel::Table since 111ccc8,
in order to properly handle queries, it's important that we properly type cast arguments.

Other Information

Should fix #28959

rafaelfranca · 2017-05-02T20:14:41Z

activerecord/lib/active_record/reflection.rb

@@ -1105,7 +1105,7 @@ def alias_candidate(name)
      end

      def alias_name
-        Arel::Table.new(table_name)
+        Arel::Table.new(table_name, type_caster: TypeCaster::Map.new(klass))


Why not klass.type_caster?

Sorry, I thought type_caster was a private method like the other Arel type methods. Updated my commit

rafaelfranca · 2017-05-02T21:05:24Z

activerecord/test/models/book.rb

@@ -1,5 +1,5 @@
 class Book < ActiveRecord::Base
-  has_many :authors


Do you need to change the association?

The schema has the _id column on the books table, not authors, https://github.com/rails/rails/blob/master/activerecord/test/schema/schema.rb#L55-L61 versus https://github.com/rails/rails/blob/master/activerecord/test/schema/schema.rb#L91

I believe I had to change it to get the test passing. Either way the way it is now is wrong

rafaelfranca

Could you add a CHANGELOG entry?

Since we have been using this `Arel::Table` since 111ccc8, in order to properly handle queries, it's important that we properly type cast arguments.

maclover7 · 2017-05-02T21:26:02Z

@rafaelfranca updated

Add type caster to `RuntimeReflection#alias_name`

rafaelfranca · 2017-05-02T21:57:03Z

Backported in f644e7a

PelagicDev · 2017-06-01T19:10:04Z

Even after upgrading to Rails 5.1.1, I'm still having this issue in my app.

# Model
class User < ApplicationRecord
  has_many :attendants, inverse_of: :user, dependent: :destroy
  has_many :event_joins, -> { where(attendee_status: [:joined, :checked_in]) }, class_name: 'Attendant'
  has_many :joined_events, through: :event_joins, source: :event
end

...and then when I try to find a user's event_joins like so, user.event_joins, I get the following error:

ActiveRecord::StatementInvalid: ActiveRecord::StatementInvalid: PG::InvalidTextRepresentation: ERROR: invalid input syntax for integer: "joined"

...and the generated SQL is:
SELECT "users"."id" FROM "users" INNER JOIN "attendants" ON "users"."id" = "attendants"."user_id" WHERE "attendants"."event_id" = $1 AND "attendants"."attendee_status" IN ('joined', 'checked_in')

- Remove ``` * Namespace error pages' CSS selectors to stop the styles from bleeding into other pages when using Turbolinks. ([Pull Request](rails#28814)) ``` since it was backported to `5-1-stable` by 50d5baf and `5-0-stable` by d1c4a39. - Remove ``` * Allow irb options to be passed from `rails console` command. ([Pull Request](rails#29010)) ``` since it was backported to `5-1-stable` by e91b483. - Remove ``` * Load environment file in `dbconsole` command. ([Pull Request](rails#29725)) ``` since it was backported to `5-1-stable` by 7f93428. - Remove ``` * Gemfile for new apps: upgrade redis-rb from ~> 3.0 to 4.0. ([Pull Request](rails#30748)) ``` since it was backported to `5-1-stable` by 3789531. - Remove ``` * Fix minitest rails plugin. The custom reporters are added only if needed. This will fix conflicts with others plugins. ([Commit](rails@ac99916)) ``` since it was backported to `5-1-stable` by caa7695. - Remove ``` * Add support for compatibility with redis-rb gem for 4.0 version. ([Pull Request](rails#30748)) ``` since it was backported to `5-1-stable` by 3789531. - Remove ``` * Add `action_controller_api` and `action_controller_base` load hooks to be called in `ActiveSupport.on_load`. ([Pull Request](rails#28402)) ``` since it was backported to `5-1-stable` by b9a5fd7. - Remove ``` * `driven_by` now registers poltergeist and capybara-webkit. ([Pull Request](rails#29315)) ``` since it was backported to `5-1-stable` by c5dd451. - Remove ``` * Fallback `ActionController::Parameters#to_s` to `Hash#to_s`. ([Pull Request](rails#29630)) ``` since it was backported to `5-1-stable` by c1014e4 and `5-0-stable` by 0e71fc3. - Remove ``` * Make `take_failed_screenshot` work within engine. ([Pull Request](rails#30421)) ``` since it was backported to `5-1-stable` by 595a231. - Remove ``` * Fix optimized url helpers when using relative url root. ([Pull Request](rails#31261)) ``` since it was backported to `5-1-stable` by e9b7795. - Remove ``` * Update `distance_of_time_in_words` helper to display better error messages for bad input. ([Pull Request](rails#20701)) ``` since it was backported to `5-1-stable` by 2c97fbf. - Remove ``` * Generate field ids in `collection_check_boxes` and `collection_radio_buttons`. ([Pull Request](rails#29412)) ``` since it was backported to `5-1-stable` by 2d8c10a. - Remove ``` * Fix issues with scopes and engine on `current_page?` method. ([Pull Request](rails#29503)) ``` since it was backported to `5-1-stable` by 2135daf. - Remove ``` * Bring back proc with arity of 1 in `ActionMailer::Base.default` proc since it was supported in Rails 5.0 but not deprecated. ([Pull Request](rails#30391)) ``` since it was backported to `5-1-stable` by b2bedb1. - Remove ``` * Add type caster to `RuntimeReflection#alias_name`. ([Pull Request](rails#28961)) ``` since it was backported to `5-1-stable` by f644e7a. - Remove ``` * Loading model schema from database is now thread-safe. ([Pull Request](rails#29216)) ``` since it was backported to `5-1-stable` by 02926cf. and `5-0-stable` by 84bcfe5 - Remove ``` * Fix destroying existing object does not work well when optimistic locking enabled and `locking_column` is null in the database. ([Pull Request](rails#28926)) ``` since it was backported to `5-1-stable` by e498052. - Remove ``` * `ActiveRecord::Persistence#touch` does not work well when optimistic locking enabled and `locking_column`, without default value, is null in the database. ([Pull Request](rails#28914)) ``` since it was backported to `5-1-stable` by 1e2f63d. - Remove ``` * Previously, when building records using a `has_many :through` association, if the child records were deleted before the parent was saved, they would still be persisted. Now, if child records are deleted before the parent is saved on a `has_many :through` association, the child records will not be persisted. ([Pull Request](rails#29593)) ``` since it was backported to `5-1-stable` by a22c39e. - Remove ``` * Query cache was unavailable when entering the `ActiveRecord::Base.cache` block without being connected. ([Pull Request](rails#29609)) ``` since it was backported to `5-1-stable` by fd6c8cd and `5-0-stable` by 9f2532b. - Remove ``` * `Relation#joins` is no longer affected by the target model's `current_scope`, with the exception of `unscoped`. ([Commit](rails@5c71000)) ``` since it was backported to `5-1-stable` by 3630d63. - Remove ``` * Fix `unscoped(where: [columns])` removing the wrong bind values. ([Pull Request](rails#29780)) ``` since it was backported to `5-1-stable` by d378fcb. - Remove ``` * When a `has_one` association is destroyed by `dependent: destroy`, `destroyed_by_association` will now be set to the reflection, matching the behaviour of `has_many` associations. ([Pull Request](rails#29855)) ``` since it was backported to `5-1-stable` by 8254a8b. - Remove ``` * Fix `COUNT(DISTINCT ...)` with `ORDER BY` and `LIMIT` to keep the existing select list. ([Pull Request](rails#29848)) ``` since it was backported to `5-1-stable` by 0e8d4ed. - Remove ``` * Ensure `sum` honors `distinct` on `has_many :through` associations. ([Commit](rails@566f1fd)) ``` since it was backported to `5-1-stable` by c0a1dc2. - Remove ``` * Fix `COUNT(DISTINCT ...)` for `GROUP BY` with `ORDER BY` and `LIMIT`. ([Commit](rails@5668dc6)) ``` since it was backported to `5-1-stable` by 87ca68e. - Remove ``` * MySQL: Don't lose `auto_increment: true` in the `db/schema.rb`. ([Commit](rails@9493d45)) ``` since it was backported to `5-1-stable` by 8b6e694. - Remove ``` * Fix longer sequence name detection for serial columns. ([Pull Request](rails#28339)) ``` since it was backported to `5-1-stable` by af9c170 and `5-0-stable` by 7025b1d. - Remove ``` * Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong ar_internal_metadata's data for a test database. ([Pull Request](rails#30579)) ``` since it was backported to `5-1-stable` by bb67b5f and `5-0-stable` by 60437e6. - Remove ``` * Fix conflicts `counter_cache` with `touch: true` by optimistic locking. ([Pull Request](rails#31405)) ``` since it was backported to `5-1-stable` by 5236dda. - Remove ``` * Fix `count(:all)` to correctly work `distinct` with custom SELECT list. ([Commit](rails@c6cd9a5)) ``` since it was backported to `5-1-stable` by 6beb4de. - Remove ``` * Fix to invoke callbacks when using `update_attribute`. ([Commit](rails@732aa34)) ``` since it was backported to `5-1-stable` by 6346683. - Remove ``` * Use `count(:all)` in `HasManyAssociation#count_records` to prevent invalid SQL queries for association counting. ([Pull Request](rails#27561)) ``` since it was backported to `5-1-stable` by eef3c89. - Remove ``` * Fix `count(:all)` with eager loading and having an order other than the driving table. ([Commit](rails@ebc09ed)) ``` since it was backported to `5-1-stable` by 6df9b69. - Remove ``` * PostgreSQL: Allow pg-1.0 gem to be used with Active Record. ([Pull Request](rails#31671)) ``` since it was backported to `5-1-stable` by a9c06f6. - Remove ``` * Fix that after commit callbacks on update does not triggered when optimistic locking is enabled. ([Commit](rails@7f9bd03)) ``` since it was backported to `5-1-stable` by aaee10e. - Remove ``` * Fix regression in numericality validator when comparing Decimal and Float input values with more scale than the schema. ([Pull Request](rails#28584)) ``` since it was backported to `5-1-stable` by 5b1c3e5. Note that there was incorrect link to PR, original PR is rails#29249. - Remove ``` * Fix to working before/after validation callbacks on multiple contexts. ([Pull Request](rails#31483)) ``` since it was backported to `5-1-stable` by 0f7046a. - Remove ``` * Fix implicit coercion calculations with scalars and durations. ([Pull Request](rails#29163), [Pull Request](rails#29971)) ``` since it was backported to `5-1-stable` by 51ea27c, 4d82e2a. - Remove ``` * Fix modulo operations involving durations. ([Commit](rails@a54e13b)) ``` since it was backported to `5-1-stable` by 233fa7e. - Remove ``` * Return all mappings for a timezone identifier in `country_zones`. ([Commit](rails@cdce6a7)) ``` since it was backported to `5-1-stable` by 0222ebb. - Remove ``` * Add support for compatibility with redis-rb gem for 4.0 version. ([Pull Request](rails#30748)) ``` since it was backported to `5-1-stable` by 3789531. Related to rails#32252. Related to rails#32222, rails#32222 (comment). Follow up a489cc8.

maclover7 added the activerecord label May 2, 2017

maclover7 mentioned this pull request May 2, 2017

5.1 Scoped associations generate SQL with enum strings instead of integers #28959

Closed

rafaelfranca requested changes May 2, 2017

View reviewed changes

maclover7 force-pushed the jm-fix-28959 branch from 0411da3 to 7009f3b Compare May 2, 2017 21:00

rafaelfranca reviewed May 2, 2017

View reviewed changes

rafaelfranca approved these changes May 2, 2017

View reviewed changes

Add type caster to RuntimeReflection#alias_name

8d64cd8

Since we have been using this `Arel::Table` since 111ccc8, in order to properly handle queries, it's important that we properly type cast arguments.

maclover7 force-pushed the jm-fix-28959 branch from 7009f3b to 8d64cd8 Compare May 2, 2017 21:25

rafaelfranca merged commit c5305f6 into rails:master May 2, 2017

rafaelfranca added a commit that referenced this pull request May 2, 2017

Merge pull request #28961 from maclover7/jm-fix-28959

f644e7a

Add type caster to `RuntimeReflection#alias_name`

maclover7 deleted the jm-fix-28959 branch May 2, 2017 23:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add type caster to `RuntimeReflection#alias_name` #28961

Add type caster to `RuntimeReflection#alias_name` #28961

maclover7 commented May 2, 2017

rafaelfranca May 2, 2017

maclover7 May 2, 2017

rafaelfranca May 2, 2017

maclover7 May 2, 2017 •

edited

rafaelfranca left a comment

maclover7 commented May 2, 2017

rafaelfranca commented May 2, 2017

PelagicDev commented Jun 1, 2017

		@@ -1,5 +1,5 @@
		class Book < ActiveRecord::Base
		has_many :authors

Add type caster to RuntimeReflection#alias_name #28961

Add type caster to RuntimeReflection#alias_name #28961

Conversation

maclover7 commented May 2, 2017

Summary

Other Information

rafaelfranca May 2, 2017

Choose a reason for hiding this comment

maclover7 May 2, 2017

Choose a reason for hiding this comment

rafaelfranca May 2, 2017

Choose a reason for hiding this comment

maclover7 May 2, 2017 • edited

Choose a reason for hiding this comment

rafaelfranca left a comment

Choose a reason for hiding this comment

maclover7 commented May 2, 2017

rafaelfranca commented May 2, 2017

PelagicDev commented Jun 1, 2017

Add type caster to `RuntimeReflection#alias_name` #28961

Add type caster to `RuntimeReflection#alias_name` #28961

maclover7 May 2, 2017 •

edited