We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a feature request to support the new JSON Feed format in auto_discovery_link_tag.
auto_discovery_link_tag
See: https://jsonfeed.org/version/1#discovery
Add an auto_discovery_link_tag using the type of :json
:json
<%= auto_discovery_link_tag(:json, "https://example.com/feed.json", title: "JSON Feed" ) %>
<link rel="alternate" title="JSON Feed" type="application/json" href="https://example.com/feed.json" />
You should pass :type tag_option key explicitly, because you have passed json type other than :rss or :atom.
This meant I had to re-write like this:
<%= auto_discovery_link_tag(nil, "https://example.com/feed.json", { title: "JSON Feed", type: "application/json" }) %>
Bummer.
Rails version: 5.1.0
Ruby version: 2.4.0
The text was updated successfully, but these errors were encountered:
@pixeltrix this issue can be closed
Sorry, something went wrong.
@bogdanvlviv @pixeltrix Can you give a reason why it was closed?
@veganstraightedge because I merged #29158 which adds support for :json to auto_discovery_link_tag 😄
Oh thanks! I missed the merger PR. 👍🏻👍🏻👍🏻
s/merger/merged/
No branches or pull requests
This is a feature request to support the new JSON Feed format in
auto_discovery_link_tag
.See: https://jsonfeed.org/version/1#discovery
Steps to reproduce
Add an
auto_discovery_link_tag
using the type of:json
Expected behavior
Actual behavior
This meant I had to re-write like this:
Bummer.
System configuration
Rails version: 5.1.0
Ruby version: 2.4.0
The text was updated successfully, but these errors were encountered: